Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Initial version of JanusGraph Python Client #2

Closed
wants to merge 2 commits into from
Closed

Adding Initial version of JanusGraph Python Client #2

wants to merge 2 commits into from

Conversation

debasishdebs
Copy link

@debasishdebs debasishdebs commented Sep 2, 2018

This is 0.0.9 version.

TODO:
Move to 1.0.0 & create 1.1.0 versions corresponding to JanusGraph 0.3.0 and Master.
Add docs for "Contributions to Lib"
Add docs "How to create connection"
Update Publish Repo from Test PyPi to PyPi

debasishdebs and others added 2 commits September 2, 2018 15:01
Signed-off-by: Debasish Kanhar <[email protected]>
Copy link

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this and for taking the time to contribute it back. Have you signed the JanusGraph CLA? Also it looks like you're asserting copyright on the files rather than releasing to JanusGraph (e.g. "Copyright 2018 JanusGraph Python Authors")?

@janusgraph-bot
Copy link

Author of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@debasishdebs
Copy link
Author

@sjudeng : Yes, my email address is added to CLA. I did contribute before (docs) for JG 0.3.0 with my official ID ([email protected]) . Check commit #d3a75c8 #80682da and both contains "Signed-off-by" with my registered email.

As for Second comment, asserting copyright statement on files, what do you mean by that? Do I need to change my Copyright from JanusGrpah-Python to JanusGraph copyright statements? If so, what are those?

@sjudeng
Copy link

sjudeng commented Sep 4, 2018

It looks like one of the commits has email address of [email protected] instead of [email protected], which is what's in the CLA signers file. In this case you could squash the merge commit with your feature commit and re-push.

Regarding copyright I noticed that many of the files indicate "Copyright 2018 Debasish Kanhar" instead of "Copyright 2018 JanusGraph Python Authors".

@debasishdebs
Copy link
Author

@sjudeng : Ah got that. Well the commit you are talking about, that is my commit message from a PR in my own branch to master. I'm actually unable to squash it (Using git rebase). I think it will be easier if I just close out this PR, delete the branch on my fork, create new branch with updated Copyright statements, update my primary github ID to IBM ID, and create a new PR here.

Does this sound good to you?

Also, what all changes will I need to make in Copyright statements? Just change to JanusGraph Python Authors?

@debasishdebs
Copy link
Author

@sjudeng : Created a new PR with updated CLA signs. Looks like that is approved too. Please have a look at PR#4 and let me know if that's correct.

Also, we can move our review/discussion there. and you can tell me about what all copyright changes needs to be done.

@pluradj
Copy link
Member

pluradj commented Sep 4, 2018

@debasishdebs next time you make the appropriate changes in your branch then do a git push -f. I'll close this PR since you've already deleted the original branch.

@pluradj pluradj closed this Sep 4, 2018
debasishdebs referenced this pull request in debasishdebs/janusgraph-python Sep 24, 2018
Added Py-Build as build tool. Able to run basic TinkerPop functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants