Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comp plugin settings tab #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

LightArrowsEXE
Copy link
Member

@LightArrowsEXE LightArrowsEXE commented Sep 8, 2024

I was going to look at refactoring this further, but the workers file traumatised me. What the fuck is this code jimbo SETSU

This PR implements the following:

  • Updated comp plugin settings tab
    • Sort settings into categories
    • Lots of refactoring and add docstrings
    • Add more useful tooltips and instructions
    • Obfuscate the API key for security reasons
      • the one we're using globally is still easily accessible in the code, but users don't have to worry about accidentally sharing their own by screenshotting the window
    • Add a table showing all the collection name template placeholders
    • Add an example output of what the collection name the user passes will render as
      • (BUG): Very long name will fuck up rendering, but >user error imo
    • Adjust the layout a bit more so it looks nicer and is easier to navigate
    • Log warnings if there are issues with the API key
  • Refactoring of the utility functions, add docstrings
  • Rename clear_filename to sanitize_filename (way clearer what it's doing)
  • Add max retries to do_single_slowpic_upload so we don't spam their API.

Example:

image

@Kapppa
Copy link
Contributor

Kapppa commented Oct 24, 2024

BTW {video_nodes} isn't the number of nodes. Its a "vs" separated list of all the nodes. For example "JPBD vs USBD vs WEB"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants