Add __init__.py to become a regular package
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `__init__.py` is required to be considered a "regular package" (<https://docs.python.org/3.11/glossary.html#term-regular-package>). Without this the `setuptools.find_packages()` in `setup.py` returns an empty list. Before: $ python -m pip install git+https://github.com/Jaded-Encoding-Thaumaturgy/getfscaler@920b4451d7968eb2ea42729600e22d7a14a3858c $ python -m getfscaler .venv\Scripts\python.exe: No module named getfscaler After: $ python -m getfscaler usage: getfscaler [-h] [--native-height NATIVE_HEIGHT] [--native_width NATIVE_WIDTH] [--crop CROP] [--frame FRAME] [--field-based FIELDS] [--swap] [--extensive] [--out] [--debug] input_file getfscaler: error: the following arguments are required: input_file
This way the program name won't appear as "__main__.py".
sgt0
commented
Nov 16, 2023
| @@ -24,6 +24,7 @@ jobs: | |||
| pip install vapoursynth-portable==${{ matrix.versions }} | |||
| pip install -r requirements.txt | |||
| pip install -r requirements-dev.txt | |||
| id: dependencies | |||
There was a problem hiding this comment.
The mypy step below wants to reference this step but this was missing an ID, so the mypy step was never running. I don't really think the if is needed because if this dependencies step fails we won't make it to the mypy step anyways.
LightArrowsEXE
merged commit 7cd966d
into
Jaded-Encoding-Thaumaturgy:main
1 check failed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
__init__.pyis required to be considered a "regular package" (https://docs.python.org/3.11/glossary.html#term-regular-package). Without this thesetuptools.find_packages()insetup.pyreturns an empty list.Before:
After:
$ python -m pip install git+https://github.com/sgt0/getfscaler@package $ python -m getfscaler usage: getfscaler [-h] [--native-height NATIVE_HEIGHT] [--native_width NATIVE_WIDTH] [--crop CROP] [--frame FRAME] [--field-based FIELDS] [--swap] [--extensive] [--out] [--debug] input_file getfscaler: error: the following arguments are required: input_fileAlso set program name for argparse so it doesn't appear as
__main__.py.Updated a couple of the GitHub actions too while I'm here.