Skip to content

Commit

Permalink
Pytest skip 2 (mosaicml#3448)
Browse files Browse the repository at this point in the history
* test

* test

* test

* test

* test

* test

* fix

* sleep before skip

* fix

* pull request target

* revert

* revery pr_target branches

* sleep 1

* 10 sec

* uncomment

* dist barrier

* test

* dist works!

* update 0.0.9

* mihir comment

Co-authored-by: Mihir Patel <[email protected]>

---------

Co-authored-by: v-chen_data <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
  • Loading branch information
3 people authored Jul 2, 2024
1 parent bea7024 commit d7032da
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/trainer/test_fsdp_checkpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,7 @@ def test_fsdp_partitioned_state_dict_load(
if weights_only and autoresume:
pytest.skip('Weights only with autoresume is not supported')
if (use_tp or use_hsdp) and version.parse(torch.__version__) < version.parse('2.3.0'):
dist.barrier() # Sync to avoid race conditions on cleaning up tmp_path
pytest.skip('HSDP and TP require torch 2.3.0 or later')

load_ignore_keys = [] if load_ignore_keys is None else load_ignore_keys
Expand Down

0 comments on commit d7032da

Please sign in to comment.