Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR-0042 and fix ADR-0036 #12277

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

InAnYan
Copy link
Collaborator

@InAnYan InAnYan commented Dec 6, 2024

  • Added a link to JavaFX Markdown UI component, that is the only one existing (for current moment).
  • Wrote ADR-0042.
  • Fixed some wording and style.

I don't know, but can I replace whole sections in one ADR by linking to whole sections in other ADR?

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
    - [ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
    - [ ] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
    - [ ] Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You modified Markdown (*.md) files and did not meet JabRef's rules for consistently formatted Markdown files.
To ensure consistent styling, we have markdown-lint in place.
Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".

@koppor
Copy link
Member

koppor commented Dec 7, 2024

I don't know, but can I replace whole sections in one ADR by linking to whole sections in other ADR?

That would be more than "Markdown". We need to check AsciiDoc or other templating engines. Filed at adr/madr#179.

@koppor koppor added this pull request to the merge queue Dec 9, 2024
Merged via the queue into JabRef:main with commit d7191c5 Dec 9, 2024
25 checks passed
@koppor koppor deleted the adr/summarization-ui branch December 9, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants