-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a test case in CitationKeyGeneratorTest.java file #12194
Closed
Closed
Changes from 5 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
c407a30
Added a test case in CitationKeyGeneratorTest.java file
yoyounik 581fb61
removed the wrong import
yoyounik 8f66b40
Updated the pattern
yoyounik df2d656
Reorganized import
yoyounik f2559e5
Remove LaTeX commands (e.g., \mkbibquote{}) using regex.
yoyounik f845041
Updated with RemoveLatexCommandsFormatter in CitationKeyGenerator.java
yoyounik dd1f97f
Added the import for RemoveLatexCommandsFormatter
yoyounik 3b1eda2
Added imports for removing OpenRewrite issue
yoyounik 784f756
updated code
yoyounik 19a80c3
updated with the import
yoyounik a5a37b9
updated with the import
yoyounik 6c4e0a8
updated with the import
yoyounik beacb03
Removed the comment
yoyounik 0368236
Updated with imports
yoyounik b70ad43
Updated with imports
yoyounik 8e4a7e1
Updated with imports
yoyounik 6fff450
Updated with imports
yoyounik 85befed
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 07064db
Instantiating the formatter as object variable
yoyounik c53891f
Instantiating the formatter as object variable
yoyounik 4868e0d
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 912e1b2
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 74dc490
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik f1c8535
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 97f968b
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 4899a18
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 28f9f2f
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik ff7925f
Updated with changes in LatexCleanupFormatter.java
yoyounik d41a9d7
Updated with changes in LatexCleanupFormatter.java
yoyounik 3c00c29
Updated cleanKey method.
yoyounik 8d9845b
Updated cleanKey method.
yoyounik 83c5841
Updated cleanKey method.
yoyounik 89b1106
Updated cleanKey method.
yoyounik d95e7e1
Merge remote-tracking branch 'origin/fix/strip-latex-from-filename' i…
yoyounik 83e3c06
Updated cleanKey method.
yoyounik 6ecdb03
Updated cleanKey method.
yoyounik 9cc84a1
Updated cleanKey method.
yoyounik 36a42f3
Updated cleanKey method.
yoyounik 25ce9a9
Updated cleanKey method.
yoyounik 0d2bea3
Updated cleanKey method.
yoyounik ab938b0
Updated
yoyounik 89d2f05
Updated
yoyounik 3e69e0c
Updated
yoyounik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -131,6 +131,15 @@ void crossrefAndInAuthorNames() { | |
database), DEFAULT_UNWANTED_CHARACTERS)); | ||
} | ||
|
||
@Test | ||
void testLatexCommandsAreStrippedFromCitationKey() throws ParseException { | ||
BibEntry entry = new BibEntry() | ||
.withField(StandardField.TITLE, "Building \\mkbibquote{Community}"); | ||
String pattern = "[bibtexkey] - [fulltitle]"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now I understand where your hacks with |
||
String generatedKey = generateKey(entry, pattern); | ||
assertEquals("BuildingCommunity", generatedKey); | ||
} | ||
|
||
@Test | ||
void andAuthorNames() throws ParseException { | ||
String bibtexString = "@ARTICLE{whatevery, author={Mari D. Herland and Mona-Iren Hauge and Ingeborg M. Helgeland}}"; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Please try to understand the comment #12188 (comment).