Fix disable some actions when no libraries are open #19129 #11928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
requested changes
Oct 12, 2024
| @@ -105,6 +106,10 @@ private void createToolBar() { | |||
| final Button pushToApplicationButton = factory.createIconButton(pushToApplicationCommand.getAction(), pushToApplicationCommand); | |||
| pushToApplicationCommand.registerReconfigurable(pushToApplicationButton); | |||
|
|
|||
| Button newEntryFromPlainTextButton = factory.createIconButton(StandardActions.NEW_ENTRY_FROM_PLAIN_TEXT, new PlainCitationParserAction(dialogService)); | |||
|
|
|||
There was a problem hiding this comment.
Remove empty line - these two statements belong together.
| @@ -118,12 +123,12 @@ private void createToolBar() { | |||
| globalSearchBar, | |||
|
|
|||
| rightSpacer, | |||
|
|
|||
There was a problem hiding this comment.
Do not add spaces. --> Place the cursor on a line with text in IntelliJ and then save.
| new HBox( | ||
| factory.createIconButton(StandardActions.NEW_ARTICLE, new NewEntryAction(frame::getCurrentLibraryTab, StandardEntryType.Article, dialogService, preferences, stateManager)), | ||
| factory.createIconButton(StandardActions.NEW_ENTRY, new NewEntryAction(frame::getCurrentLibraryTab, dialogService, preferences, stateManager)), | ||
| createNewEntryFromIdButton(), | ||
| factory.createIconButton(StandardActions.NEW_ENTRY_FROM_PLAIN_TEXT, new PlainCitationParserAction(dialogService)), | ||
| newEntryFromPlainTextButton, // Use the modified button here |
There was a problem hiding this comment.
No need for the comment - it is self explainiing
Suggested change
| newEntryFromPlainTextButton, // Use the modified button here | |
| newEntryFromPlainTextButton, |
(Did you use ChatGPT? This comment is AI generated, isn't it?)
Comment on lines
+150
to
+154
| MenuItem saveAllMenuItem = factory.createMenuItem(StandardActions.SAVE_ALL, new SaveAllAction(frame::getLibraryTabs, preferences, dialogService)); | ||
| MenuItem newEntryFromPlainTextMenuItem = factory.createMenuItem(StandardActions.NEW_ENTRY_FROM_PLAIN_TEXT, new PlainCitationParserAction(dialogService)); | ||
|
|
||
| saveAllMenuItem.disableProperty().bind(Bindings.isEmpty(stateManager.getOpenDatabases())); | ||
| newEntryFromPlainTextMenuItem.disableProperty().bind(Bindings.isEmpty(stateManager.getOpenDatabases())); |
There was a problem hiding this comment.
Reorder:
Variable declaration and binding should be grouped.
Now you have
- A-init
- B-init
- empty line
- A-binding
- B-binding
It shoudl be
- A-init
- A-binding
- empty line
- B-init
- B-binding
There was a problem hiding this comment.
ok, I will change it.
|
please do not delete and re-create your PR! justpush your changes! PR will be auto updted |
|
Follow up PR is #11936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the user interface by disabling certain menu items and toolbar buttons when no library is open.
Specifically:
"Save All" menu item in MainMenu.java is now disabled (greyed out) when there are no open libraries.
"New entry from plain text" menu item in MainMenu.java is now disabled when there are no open libraries.
"Global Search" bar in the main toolbar (MainToolBar.java) is now disabled when there are no open libraries.
"New entry from plain text" button in the main toolbar (MainToolBar.java) is now disabled when there are no open libraries.
Here's the screenshot:
Here's the demo video:
2024-10-12.19-15-50.mp4
Closes #19129
#11923
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)