Merge branch 'main' into postgresql

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,10 +1,5 @@
-<!-- 
-Describe the changes you have made here: what, why, ... 
-Link the issue that will be closed, e.g., "Closes #333".
-If your PR closes a koppor issue, link it using its URL, e.g., "Closes https://github.com/koppor/jabref/issues/47".
-"Closes" is a keyword GitHub uses to link PRs with issues; do not change it.
-Don't reference an issue in the PR title because GitHub does not support auto-linking there.
--->
+Describe the changes you have made here: what, why, ...
+Link the issue that will be closed, e.g., "Closes #333". If your PR closes a koppor issue, link it using its URL, e.g., "Closes https://github.com/koppor/jabref/issues/47".
 
 ### Mandatory checks
 

.github/workflows/assign-issue.yml

@@ -10,25 +10,47 @@ on:
 jobs:
   assign:
     runs-on: ubuntu-latest
+    permissions:
+      issues: write
     steps:
       - name: Assign the user or unassign stale assignments
-        uses: takanome-dev/[email protected]
+        id: assign
+        uses: takanome-dev/assign-issue-action@beta
         with:
           github_token: '${{ secrets.GITHUB_TOKEN }}'
           days_until_unassign: 30
+          maintainers: koppor, Siedlerchr, ThiloteE, calixtus, HoussemNasri
           assigned_comment: |
-            👋 Hey @{{ comment.user.login }},
+            👋 Hey @{{ handle }}, thank you for your interest in this issue! 🎉
 
-            Thanks for your interest in this issue! 🎉
-
-            Newcomers, we're excited to have you on board. Start by exploring our [Contributing](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md) guidelines, and don't forget to check out our [workspace setup guidelines](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace) to get started smoothly.
+            We're excited to have you on board. Start by exploring our [Contributing](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md) guidelines, and don't forget to check out our [workspace setup guidelines](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace) to get started smoothly.
 
             In case you encounter failing tests during development, please check our [developer FAQs](https://devdocs.jabref.org/code-howtos/faq.html)!
 
             Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on [JabRef's Gitter chat](https://gitter.im/JabRef/jabref). And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.
 
-            ⚠ Note that this issue will become unassigned if it isn't closed within **{{ totalDays }} days**.
-
-            🔧 A maintainer can also add the **{{ inputs.pin_label }}** label to prevent it from being unassigned automatically.
-
             Happy coding! 🚀
+
+            ⏳ Please note, you will be automatically unassigned if the issue isn't closed within **{{ total_days }} days** (by **{{ unassigned_date }}**). A maintainer can also add the "**{{ pin_label }}**"" label to prevent automatic unassignment.
+      - name: Move Issue to "Assigned" Column in "Candidates for University Projects"
+        if: steps.assign.outputs.assigned == 'yes'
+        uses: m7kvqbe1/github-action-move-issues@feat/skip-if-not-in-project-flag
+        with:
+          github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+          project-url: "https://github.com/orgs/JabRef/projects/3"
+          target-labels: "📍 Assigned"
+          target-column: "Assigned"
+          ignored-columns: ""
+          default-column: "Free to take"
+          skip-if-not-in-project: true
+      - name: Move Issue to "Assigned" Column in "Good First Issues"
+        if: steps.assign.outputs.assigned == 'yes'
+        uses: m7kvqbe1/github-action-move-issues@feat/skip-if-not-in-project-flag
+        with:
+          github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+          project-url: "https://github.com/orgs/JabRef/projects/5"
+          target-labels: "📍 Assigned"
+          target-column: "Assigned"
+          ignored-columns: ""
+          default-column: "Free to take"
+          skip-if-not-in-project: true

.github/workflows/automerge.yml

@@ -10,13 +10,13 @@ jobs:
     runs-on: ubuntu-latest
     # Run only if PR is inside JabRef's main repository and created by dependabot or by an update workflow
     if: >
-      (github.repository == 'JabRef/jabref') && 
+      (github.repository == 'JabRef/jabref') &&
       (github.event.pull_request.head.repo.full_name == 'JabRef/jabref') &&
       (
         (github.actor == 'dependabot[bot]') ||
         (
-          startsWith(github.event.pull_request.title, '[Bot] ') || 
-          startsWith(github.event.pull_request.title, 'Bump ') || 
+          startsWith(github.event.pull_request.title, '[Bot] ') ||
+          startsWith(github.event.pull_request.title, 'Bump ') ||
           startsWith(github.event.pull_request.title, 'New Crowdin updates') ||
           startsWith(github.event.pull_request.title, 'Update Gradle Wrapper from')
         )
@@ -26,9 +26,9 @@ jobs:
         run: gh pr review --approve "$PR_URL"
         env:
           PR_URL: ${{github.event.pull_request.html_url}}
-          GITHUB_TOKEN: ${{secrets.GH_TOKEN_JABREF_MACHINE_PR_APPROVE}}
+          GH_TOKEN: ${{secrets.GH_TOKEN_JABREF_MACHINE_PR_APPROVE}}
       - name: Merge PR
         run: gh pr merge --auto --squash "$PR_URL"
         env:
           PR_URL: ${{github.event.pull_request.html_url}}
-          GITHUB_TOKEN: ${{secrets.GH_TOKEN_UPDATE_GRADLE_WRAPPER}}
+          GH_TOKEN: ${{secrets.GH_TOKEN_UPDATE_GRADLE_WRAPPER}}

.github/workflows/cleanup-pr.yml

@@ -39,6 +39,6 @@ jobs:
         if: steps.checksecrets.outputs.secretspresent == 'YES'
         uses: thollander/actions-comment-pull-request@v3
         with:
-          comment_tag: download-link
+          comment-tag: download-link
           message: The build for this PR is no longer available. Please visit <https://builds.jabref.org/main/> for the latest build.
           mode: upsert

.github/workflows/deployment-arm64.yml

@@ -205,7 +205,7 @@ jobs:
         if: ${{ (!startsWith(github.ref, 'refs/heads/gh-readonly-queue')) && (steps.checksecrets.outputs.secretspresent == 'YES') && ((matrix.os == 'ubuntu-latest') || ((matrix.os == 'macos-14') && !((startsWith(github.ref, 'refs/tags/') || inputs.notarization == true)))) }}
         shell: bash
         run: |
-          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'ssh -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/
+          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'ssh -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/ || true
       - name: Upload to GitHub workflow artifacts store (macOS)
         if: (matrix.os == 'macos-14') && (steps.checksecrets.outputs.secretspresent == 'YES') && (startsWith(github.ref, 'refs/tags/') || inputs.notarization == true)
         uses: actions/upload-artifact@v4

.github/workflows/deployment-jdk-ea.yml

@@ -266,7 +266,7 @@ jobs:
         shell: cmd
         # for rsync installed by chocolatey, we need the ssh.exe delivered with that installation
         run: |
-          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/jdk-ea && rsync" -e 'C:\ProgramData\chocolatey\lib\rsync\tools\bin\ssh.exe -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/jdk-ea/
+          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/jdk-ea && rsync" -e 'C:\ProgramData\chocolatey\lib\rsync\tools\bin\ssh.exe -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/jdk-ea/ || true
       - name: Upload to builds.jabref.org (linux, macOS)
         if: (matrix.os != 'windows-latest') && (steps.checksecrets.outputs.secretspresent == 'YES') && (github.ref == 'refs/heads/main')
         shell: bash

.github/workflows/deployment.yml

@@ -242,15 +242,15 @@ jobs:
         shell: cmd
         # for rsync installed by chocolatey, we need the ssh.exe delivered with that installation
         run: |
-          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'C:\ProgramData\chocolatey\lib\rsync\tools\bin\ssh.exe -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/
+          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'C:\ProgramData\chocolatey\lib\rsync\tools\bin\ssh.exe -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/ || true
       - name: Upload to builds.jabref.org (linux, macOS)
         # macOS: Negated condition of "Upload to GitHub workflow artifacts store (macOS)"
         #        Reason: We either upload the non-notarized files - or notarize the files later (and upload these later)
         # needs to be on one line; multi line does not work
         if: ${{ (!startsWith(github.ref, 'refs/heads/gh-readonly-queue')) && (steps.checksecrets.outputs.secretspresent == 'YES') && ((matrix.os == 'ubuntu-latest') || ((matrix.os == 'macos-13') && !((startsWith(github.ref, 'refs/tags/') || inputs.notarization == true)))) }}
         shell: bash
         run: |
-          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'ssh -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/
+          rsync -rt --chmod=Du=rwx,Dg=rx,Do=rx,Fu=rw,Fg=r,Fo=r --itemize-changes --stats --rsync-path="mkdir -p /var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }} && rsync" -e 'ssh -p 9922 -i sshkey -o StrictHostKeyChecking=no' build/distribution/ [email protected]:/var/www/builds.jabref.org/www/${{ steps.gitversion.outputs.branchName }}/ || true
       - name: Upload to GitHub workflow artifacts store (macOS)
         if: (matrix.os == 'macos-13') && (steps.checksecrets.outputs.secretspresent == 'YES') && (startsWith(github.ref, 'refs/tags/') || inputs.notarization == true)
         uses: actions/upload-artifact@v4
@@ -291,7 +291,7 @@ jobs:
         with:
           message: |
             The build of this PR is available at <https://builds.jabref.org/pull/${{ github.event.pull_request.number }}/merge>.
-          comment_tag: download-link
+          comment-tag: download-link
           mode: recreate
   notarize: # outsourced in a separate job to be able to rerun if this fails for timeouts
     name: macOS notarization

.github/workflows/on-labeled.yml → .github/workflows/on-labeled-issue.yml

@@ -1,12 +1,9 @@
-name: On labeled
+name: On labeled issue
 
 on:
   issues:
      types:
        - labeled
-  pull_request_target:
-    types:
-       - labeled
 
 jobs:
   FirstTimeCodeContribution:
@@ -28,46 +25,31 @@ jobs:
 
           Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on [JabRef's Gitter chat](https://gitter.im/JabRef/jabref). And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.
 
+          ⚠ Note that this issue will become unassigned if it isn't closed within **30 days**.
+
+          🔧 A maintainer can also add the **`Pinned`** label to prevent it from being unassigned automatically.
+
           Happy coding! 🚀
     - name: Move Issue to "Assigned" Column in "Candidates for University Projects"
-      uses: m7kvqbe1/[email protected]
-      with:
-       github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
-       project-url: "https://github.com/orgs/JabRef/projects/3"
-       target-labels: "FirstTimeCodeContribution"
-       target-column: "Assigned"
-       ignored-columns: ""
-    - name: Move Issue to "Assigned" Column in "Good First Issues"
-      uses: m7kvqbe1/[email protected]
-      with:
-       github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
-       project-url: "https://github.com/orgs/JabRef/projects/5"
-       target-labels: "FirstTimeCodeContribution"
-       target-column: "Assigned"
-       ignored-columns: ""
-  Assigned:
-    name: "📍 Assigned"
-    if: ${{ github.event.label.name == '📍 Assigned' }}
-    runs-on: ubuntu-latest
-    permissions:
-      issues: write
-    steps:
-    - name: Move Issue to "Assigned" Column in "Candidates for University Projects"
-      uses: m7kvqbe1/[email protected]
+      uses: m7kvqbe1/github-action-move-issues@feat/skip-if-not-in-project-flag
       with:
-       github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
-       project-url: "https://github.com/orgs/JabRef/projects/3"
-       target-labels: "📍 Assigned"
-       target-column: "Assigned"
-       ignored-columns: ""
+        github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+        project-url: "https://github.com/orgs/JabRef/projects/3"
+        target-labels: "📍 Assigned"
+        target-column: "Assigned"
+        ignored-columns: ""
+        default-column: "Free to take"
+        skip-if-not-in-project: true
     - name: Move Issue to "Assigned" Column in "Good First Issues"
-      uses: m7kvqbe1/github-action-move-issues@v1.0.9
+      uses: m7kvqbe1/github-action-move-issues@feat/skip-if-not-in-project-flag
       with:
-       github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
-       project-url: "https://github.com/orgs/JabRef/projects/5"
-       target-labels: "📍 Assigned"
-       target-column: "Assigned"
-       ignored-columns: ""
+        github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+        project-url: "https://github.com/orgs/JabRef/projects/5"
+        target-labels: "📍 Assigned"
+        target-column: "Assigned"
+        ignored-columns: ""
+        default-column: "Free to take"
+        skip-if-not-in-project: true
   good-first-issue:
     name: "good first issue"
     if: "${{ github.event.label.name == 'good first issue' }}"

.github/workflows/on-labeled-pr.yml

@@ -0,0 +1,23 @@
+name: On labeled PR
+
+on:
+  pull_request:
+     types:
+       - labeled
+
+jobs:
+  automerge:
+    name: Auto Merge
+    if: "${{ github.event.label.name == 'automerge' }}"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Approve PR
+        run: gh pr review --approve "$PR_URL"
+        env:
+          PR_URL: ${{github.event.pull_request.html_url}}
+          GITHUB_TOKEN: ${{secrets.GH_TOKEN_JABREF_MACHINE_PR_APPROVE}}
+      - name: Merge PR
+        run: gh pr merge --auto --squash "$PR_URL"
+        env:
+          PR_URL: ${{github.event.pull_request.html_url}}
+          GITHUB_TOKEN: ${{secrets.GH_TOKEN_UPDATE_GRADLE_WRAPPER}}

.github/workflows/on-review-submitted.yml

@@ -0,0 +1,17 @@
+name: On reviewed PR
+
+on:
+  pull_request_review:
+     types:
+       - submitted
+
+jobs:
+  add-label-changes-required:
+    runs-on: ubuntu-latest
+    steps:
+      - run: |
+          gh pr edit "$PR_URL" --remove-label "status: ready-for-review"
+          gh pr edit "$PR_URL" --add-label "status: changes required"
+        env:
+          PR_URL: ${{github.event.pull_request.html_url}}
+          GH_TOKEN: ${{secrets.GH_TOKEN_UPDATE_GRADLE_WRAPPER}}

.github/workflows/on-unlabeled-issue.yml

@@ -0,0 +1,34 @@
+name: On unlabeled issue
+
+on:
+  issues:
+     types:
+       - unlabeled
+
+jobs:
+  FirstTimeCodeContribution_or_Assigned:
+    if: ${{ (github.event.label.name == 'FirstTimeCodeContribution') || (github.event.label.name == '📍 Assigned') }}
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+    - name: Move Issue to "Free to take" Column in "Candidates for University Projects"
+      uses: m7kvqbe1/github-action-move-issues@feat/skip-if-not-in-project-flag
+      with:
+        github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+        project-url: "https://github.com/orgs/JabRef/projects/3"
+        target-labels: "📍 Assigned"
+        target-column: "Assigned"
+        ignored-columns: ""
+        default-column: "Free to take"
+        skip-if-not-in-project: true
+    - name: Move Issue to "Free to take" Column in "Good First Issues"
+      uses: m7kvqbe1/github-action-move-issues@feat/skip-if-not-in-project-flag
+      with:
+        github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+        project-url: "https://github.com/orgs/JabRef/projects/5"
+        target-labels: "📍 Assigned"
+        target-column: "Assigned"
+        ignored-columns: ""
+        default-column: "Free to take"
+        skip-if-not-in-project: true

.github/workflows/tests.yml

@@ -347,6 +347,8 @@ jobs:
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v4
       - run: ./gradlew traceRequirements
+      - if: failure()
+        run: cat build/reports/tracing.txt
 
   # This is https://github.com/marketplace/actions/gradle-wrapper-validation
   # It ensures that the jar file is from gradle and not by a strange third party.

.vscode/ltex.dictionary.en-US.txt

@@ -2,4 +2,5 @@ Checkstyle
 CouchDB
 JabDrive
 JabRef
+OpenFastTrace
 OpenRewrite