feature: 채팅 구현 #44
Merged
feature: 채팅 구현 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- String 255자 기본 length이기에 삭제 - @builder에서 createdAt 파라미터 불필요
- websocket - stomp
- sendMessage
- sendChatMessage 채팅 구현
LJH098
requested changes
Nov 13, 2024
Comment on lines
24
to
31
| Workspace workspace = | ||
| workspaceRepository | ||
| .findById(chatRoomId) | ||
| .orElseThrow(() -> new IllegalArgumentException("유효하지 않은 채팅방 id입니다.")); | ||
| User user = | ||
| userRepository | ||
| .findById(userPk) | ||
| .orElseThrow(() -> new IllegalArgumentException("유효하지 않은 사용자 id입니다.")); |
There was a problem hiding this comment.
저희가 예외처리 할 때 new IllegalArgumentException("유효하지 않은 사용자 id입니다."); 이런 식으로 예외를 생성하지 않는 것 같은데 UserError를 참고해주세요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 작업 내용
📷 스크린샷(선택)
💬 리뷰 요구사항