feature: PR #11 코드 리뷰 반영 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- findByVisitorMatch->findParticipantIdByWorkspaceId - existsById->isClickedById
- Optional에 대한 orElseThrow처리
- Modifying 추가
LJH098
requested changes
Nov 3, 2024
Comment on lines
17
to
18
| @Query(value = "SELECT COUNT(p) >0 FROM Participant p WHERE p.id=:id AND p.participantMatch=true") | ||
| Boolean isClickedById(long id); |
There was a problem hiding this comment.
Boolean existsByIdAndAndParticipantMatchTrue(long id);
위처럼 JPQL을 사용하지 않고 Data JPA를 사용 할 수도 있을 것 같아요
그리고 isClicekd는 너무 추상적인 단어 인 것 같아요.
| GetWorkspacesResponse.of( | ||
| workspace.getId(), workspace.getCreator().getUid())) | ||
| .filter(workspace -> workspace.getCreatedAt().isBefore(dateFilter)) //게임방 조회: 유지 시간은 24h | ||
| .map(workspace ->GetWorkspacesResponse.of(workspace.getId(), workspace.getCreator().getUid())) | ||
| .toList(); |
There was a problem hiding this comment.
현재는 머지가 된 상태입니다!
- findByUid
LJH098
force-pushed
the
develop
branch
3 times, most recently
from
e657b04
to
c2e417d
Compare
- 기존의 JPQL에서 Data JPA를 사용하는 것으로 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 작업 내용
📷 스크린샷(선택)
💬 리뷰 요구사항