Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional student guidance #18

Merged
merged 9 commits into from
Nov 10, 2022

Conversation

l-gorman
Copy link

@l-gorman l-gorman commented Sep 21, 2022

Draft PR to implement changes which need to
be made before the new members of ask JGI team joint

Further updates to add #19

@l-gorman l-gorman requested a review from jatonline September 21, 2022 14:26
@l-gorman l-gorman marked this pull request as ready for review October 5, 2022 10:42
@l-gorman l-gorman marked this pull request as draft October 5, 2022 11:47
@jatonline
Copy link
Member

Looks good! :) Happy to merge this or if you want to make further changes here following today's meeting then go for it!

@jatonline jatonline force-pushed the additional-student-guidance branch from 952ffa3 to 5ccc208 Compare October 10, 2022 11:43
@jatonline
Copy link
Member

@l-gorman as discussed, I've suggested some (minor) changes.

Happy for you to continue with the other things you think are needed:

  1. Add some details about the tracker (filling it in etc…)
  2. Add new links to the new sharepoint folders
  3. Edit the shift organization page so it is accurate for having one shifter on at a time

...with the links to SharePoint, Tracker, Slack, etc. I wonder if it's worth linking to a (newly-created) single page that links to everything external?

  • this could be a useful bookmark for people
  • and would mean only one place to edit when links change

(See what you think)

I've added @RichardP1234 to review in my absence :)

@jatonline jatonline marked this pull request as ready for review November 10, 2022 11:39
@jatonline
Copy link
Member

Based on our group discussion today, we're going to merge this PR as-is now, and open up new issues for any remaining work. :)

Thanks @l-gorman and @RichardP1234 for your help! 🎉

@jatonline jatonline merged commit 662552a into JGIBristol:main Nov 10, 2022
@jatonline jatonline mentioned this pull request Nov 10, 2022
3 tasks
@l-gorman
Copy link
Author

Thanks @jatonline! Sorry I didn't get round to the final changes 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants