Many many fixes #27
Merged
Many many fixes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work with poetry.
Before: ``` $ poetry run asv run --python=same --show-stderr -b Unique ... [ 50.00%] ··· benchmarks.TimeUnique.time_const12_base 6.31±0.2ms [100.00%] ··· benchmarks.TimeUnique.time_const12_rle 40.6±0.9ms ``` After: ``` $ poetry run asv run --python=same --show-stderr -b Unique ... [ 50.00%] ··· benchmarks.TimeUnique.time_const12_base 6.45±0.07ms [100.00%] ··· benchmarks.TimeUnique.time_const12_rle 188±2μs ```
Before: ``` $ poetry run asv run --python=same --show-stderr -b Compress ... [100.00%] ··· benchmarks.TimeCompression.time_decompress 7.11±0.5ms ``` After: ``` $ poetry run asv run --python=same --show-stderr -b Compress ... [100.00%] ··· benchmarks.TimeCompression.time_decompress 4.23±0.2ms ```
Before: ``` $ poetry run asv run --python=same --show-stderr -b Compress ... [ 50.00%] ··· benchmarks.TimeCompression.time_decompress_array_astype 4.37±0.3ms [100.00%] ··· benchmarks.TimeCompression.time_decompress_to_numpy 1.60±0.3ms ``` After: ``` $ poetry run asv run --python=same --show-stderr -b Compress ... [ 50.00%] ··· benchmarks.TimeCompression.time_decompress_array_astype 3.04±0.3ms [100.00%] ··· benchmarks.TimeCompression.time_decompress_to_numpy 844±100μs ```
Before: ``` $ poetry run asv run --python=same --show-stderr -b Factorize ... [ 50.00%] ··· benchmarks.TimeFactorize.time_const12_base 11.2±0.2ms [100.00%] ··· benchmarks.TimeFactorize.time_const12_rle 73.7±0.7ms ``` After: ``` $ poetry run asv run --python=same --show-stderr -b Factorize ... [ 50.00%] ··· benchmarks.TimeFactorize.time_const12_base 10.7±0.2ms [100.00%] ··· benchmarks.TimeFactorize.time_const12_rle 3.68±0.1ms ```
marco-neumann-by
force-pushed
the
misc_fixes_1
branch
from
ca00500 to
0d9cb39
Compare
hendrik-teuber-by
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. That all came up when battle-testing
rle-arrayon some internal project.