This repository has been archived by the owner on Dec 17, 2020. It is now read-only.
Trace in the Oven #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkollar
force-pushed
the
trace-in-the-oven
branch
4 times, most recently
from
d61ef1b
to
bd70415
Compare
|
Review requested. |
xkollar
force-pushed
the
trace-in-the-oven
branch
from
bd70415
to
491172e
Compare
|
I made a minor change in the examples (to make more visible, that we can really make a function with traces and run it as if being pure at the same time). Sorry if you have already started review |
xkollar
force-pushed
the
trace-in-the-oven
branch
2 times, most recently
from
491172e
to
9fc431a
Compare
xkollar
force-pushed
the
trace-in-the-oven
branch
from
9fc431a
to
be12fd1
Compare
|
@liskin: No particular reason. I'll give it a try should I find couple of moments to spare |
Make Trace effect composable and make it possible to trace any value, not just String. Some convenient handlers provided.
Structure similar to Reader effect. (Hopefully) inspiring example.
xkollar
force-pushed
the
trace-in-the-oven
branch
from
be12fd1
to
50660ca
Compare
|
@liskin:I have rewritten handler to use |
xkollar
force-pushed
the
trace-in-the-oven
branch
from
50660ca
to
61762ed
Compare
|
I would love to get this to master… |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace seems to be one of those half-baked effects (#10). This is attempt to fix it.