Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first class support to Wikidata in the backend #2075

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Add first class support to Wikidata in the backend #2075

merged 9 commits into from
Nov 13, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Nov 13, 2024

  • It adds a Wikidata source (that will replace the he and en wikipedia sources in the future).
  • It allows adding links to Wikidata from the POI edit window.
  • It merges between Wikidata and Wikipedia, and between OSM and Wikidata
  • It merges iNature links as well (ref:IL:inature) as part of the merge algorithm
  • It removes the updates and track of deleted POIs (in continue to Move Points of interest to use tiles #1979 )
  • Resolves Add support for wikidata #2007

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.46%. Comparing base (36c817b) to head (a1b30db).

Files with missing lines Patch % Lines
...sraelHiking.API/Executors/FeaturesMergeExecutor.cs 91.66% 4 Missing and 2 partials ⚠️
...iking.API/Services/Poi/PointsOfInterestProvider.cs 91.30% 0 Missing and 2 partials ⚠️
...PI/Services/Poi/WikidataPointsOfInterestAdapter.cs 94.73% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2075      +/-   ##
==========================================
+ Coverage   90.43%   90.46%   +0.03%     
==========================================
  Files         100      101       +1     
  Lines        8520     8572      +52     
  Branches     1070     1074       +4     
==========================================
+ Hits         7705     7755      +50     
- Misses        586      589       +3     
+ Partials      229      228       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit f03ad4d into main Nov 13, 2024
6 of 7 checks passed
@HarelM HarelM deleted the wikidata branch November 13, 2024 21:46
HarelM added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for wikidata
3 participants