Fix missing dependency #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DonRichards Can you review and merge this PR given #262 and #276 are merged but the dependency requirement hasn't been added yet; please? |
|
@DonRichards Can you have a look at this given the original work was completed by you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: (https://jira.lyrasis.org/browse/ISLANDORA-2501)
#262
What does this Pull Request do?
Adds a dependency on Islandora
What's new?
#262 uses an Islandora function, but no dependency is declared. This PR fixes the problem.
Note that the README lists Islandora under Requirements, but no hard dependency until now.
How should this be tested?
To confirm the dependency is correctly set:
Interested parties
@adam-vessey @DonRichards