Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint #994

Merged
merged 2 commits into from
Nov 3, 2023
Merged

lint #994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
779e892
lint
joecorall Nov 3, 2023
f3d4bdf
Update JsonldTypeAlterReactionTest.php
joecorall Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions tests/src/Functional/JsonldTypeAlterReactionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,21 @@ public function testMappingReaction() {
}
else {
$this->getSession()->getPage()->selectFieldOption('new_storage_type', 'plain_text');
// first need to submit the form with the elements displayed on initial page load
// the form is using AJAX to send a second element after we selected the radio button above
// we can instead get the second element by submitting the form and having it throw an error
// since the required field is missing
// @TODO: refactor this as a functional javascript test maybe?
// though we currently don't have selenium running for our tests so not possible ATM
// First need to submit the form with the elements displayed
// on initial page load. The form is using AJAX to send a second element
// after we selected the radio button above
// we can instead get the second element by submitting the form
// and having it throw an error since the required field is missing.
// @todo refactor this as a functional javascript test.
$this->submitForm([
'new_storage_type' => 'plain_text',
'label' => 'Typed Predicate',
'field_name' => 'type_predicate',
], $this->t('Continue'));

// now we can proceed, selecting the plain text (i.e. string) for the second element
// now that the element is displayed after the initial form submission
// Now we can proceed, selecting the plain text (i.e. string)
// for the second element now that the element is displayed after
// the initial form submission.
$this->getSession()->getPage()->selectFieldOption('group_field_options_wrapper', 'string');
$this->submitForm([
'new_storage_type' => 'plain_text',
Expand Down