Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.2 <strike>and Drupal 10.2</strike> to testing matrix #987

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 25, 2023

GitHub Issue: Islandora/documentation#2262

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)
    Discussed at Committers Call Oct 18, 2023

What does this Pull Request do?

Adds PHP 8.2 and Drupal 10.2 to the testing matrix. Removes Drupal 9.5 (6 days till EOL).

How should this be tested?

Check the tests! Likely they will fail, and/or reveal some deprecations and other things we need to take care of. This should probably be merged anyway and the tests dealt with separately.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@rosiel
Copy link
Member Author

rosiel commented Oct 25, 2023

Note from tech call - remove known failing 10.2 from matrix.

DonRichards
DonRichards previously approved these changes Oct 27, 2023
@DonRichards DonRichards self-requested a review October 27, 2023 20:36
@DonRichards DonRichards dismissed their stale review October 27, 2023 20:36

unintended

@DonRichards
Copy link
Member

Sorry, I didn't fully test.

@rosiel rosiel changed the title Add PHP 8.2 and Drupal 10.2 to testing matrix Add PHP 8.2 ~and Drupal 10.2~ to testing matrix Oct 30, 2023
@rosiel rosiel changed the title Add PHP 8.2 ~and Drupal 10.2~ to testing matrix Add PHP 8.2 </strike>and Drupal 10.2</strike> to testing matrix Oct 30, 2023
@rosiel rosiel changed the title Add PHP 8.2 </strike>and Drupal 10.2</strike> to testing matrix Add PHP 8.2 <strike>and Drupal 10.2</strike> to testing matrix Oct 30, 2023
@seth-shaw-asu seth-shaw-asu merged commit d5556f4 into 2.x Nov 1, 2023
12 checks passed
@seth-shaw-asu seth-shaw-asu deleted the rosiel-patch-2 branch November 1, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants