Header link settings #1038
Open
Header link settings #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, looks like we had a little coding standards issue merged in that's making a mess of the code checks here ( which was addressed in #1040 ). Could you please merge or rebase against |
AronNovak
force-pushed
the
header-link-settings
branch
from
3a80cdc to
ce54e62
Compare
|
@adam-vessey Done, now the tests are green. |
|
Is there anything I can do to move this forward? |
adam-vessey
reviewed
Oct 2, 2024
| @@ -2,3 +2,4 @@ broker_url: 'tcp://localhost:61613' | |||
| jwt_expiry: '+2 hour' | |||
| delete_media_and_files: TRUE | |||
| gemini_pseudo_bundles: [] | |||
| allow_header_links: TRUE | |||
There was a problem hiding this comment.
An update hook should be implemented to create/populate this new configuration value when updating existing installations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1039
Status