Skip to content

Commit

Permalink
revert setting up chromedriver.
Browse files Browse the repository at this point in the history
  • Loading branch information
rosiel committed Jul 22, 2022
1 parent 07e3c49 commit eb53ff4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
14 changes: 3 additions & 11 deletions .github/workflows/build-2.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ["7.4", "8.0"]
# PHP 8.1 fails - see https://github.com/Islandora/islandora/issues/887
php-versions: ["7.4", "8.0"]
# test-suite functional-javascript will appear to pass but will skip tests; missing chromedriver.
test-suite: ["kernel", "functional", "functional-javascript"]
drupal-version: ["9.3.x", "9.4.x", "9.5.x-dev"]
# Not yet Drupal 10 ready - see https://github.com/Islandora/islandora/issues/888
drupal-version: ["9.3.x", "9.4.x", "9.5.x-dev"]
mysql: ["8.0"]
allowed_failure: [false]

Expand Down Expand Up @@ -118,15 +119,6 @@ jobs:
- name: Test scripts
run: $SCRIPT_DIR/travis_scripts.sh

# needed for FunctionalJavascript
- name: Setup chromedriver
uses: nanasess/setup-chromedriver@v1

- name: Start chromedriver
run: |
export DISPLAY=:99
chromedriver --port=4444 --no-sandbox --url-base=/wd/hub &
- name: PHPUNIT tests
run: |
cd $DRUPAL_DIR/web/core
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<!-- Example for changing the driver args to phantomjs tests MINK_DRIVER_ARGS_PHANTOMJS value: '["http://127.0.0.1:8510"]' -->
<env name="MINK_DRIVER_ARGS_PHANTOMJS" value=""/>
<!-- Example for changing the driver args to webdriver tests MINK_DRIVER_ARGS_WEBDRIVER value: '["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]' For using the Firefox browser, replace "chrome" with "firefox" -->
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", { "chromeOptions": { "w3c": false } }, "http://localhost:4444/wd/hub"]'/>
<env name="MINK_DRIVER_ARGS_WEBDRIVER" value=""/>
</php>
<testsuites>
<testsuite name="unit">
Expand Down

0 comments on commit eb53ff4

Please sign in to comment.