Add Drupal 10+ CSS/JS Aggregation support #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
requested changes
Jun 5, 2024
nigelgbanks
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CSS/JS aggregation enabled in Drupal 10, nginx needs to first check if the CSS/JS exists on disk. If not, needs to forward the request to Drupal/php
How to test
Using
ISLANDORA_TAG=3.2see that when CSS/JS aggregation is enabled in your Drupal stack, your theme's page displays are brokenUsing this PR's tag
ISLANDORA_TAG=d10-css-js-aggregationssee that CSS/JS aggregation works as expectedRelated conversations
https://islandora.slack.com/archives/C019U12D44Q/p1717446855079619?thread_ts=1699377978.424099&cid=C019U12D44Q