Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard coded settings for twig debug #331

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

joshdentremont
Copy link
Collaborator

Removes the forced twig debug settings when code-server is included.

Having twig debugging on causes lots of HTML comments in the code, which messes up Views' ability to hide empty fields (https://www.drupal.org/project/drupal/issues/2908634). This means that configuring your solr search results view in the dev environment doesn't hide empty fields so you don't know if it's working until you push the config to production.

This PR removes the automatic enabling of twig debugging from code-server so you can now toggle it on and off as normal through Drupal's settings at /admin/config/development/settings

To test:

  • Start a new site using the site template, or other method that includes code-server, and inspect the HTML for twig debug comments
    • Test that this can not be turned off at /admin/config/development/settings
  • Clear the site and start another new one with the code-server image built from this PR, and inspect the HTML to see the comments are not there
    • Test that this can be toggled on and off at /admin/config/development/settings

@nigelgbanks nigelgbanks merged commit 14940c5 into Islandora-Devops:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants