Let site (starter or otherwise) set media urls. #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: in part, addresses #248
Release pull requests, etc.)
What does this Pull Request do?
Doesn't set media urls to have "Standalone URLs". This configuration is part of the starter site / install profile / whatever site you're using. The playbook currently insists on overriding whatever value you have set there in your site, which I think it shouldn't do.
What's new?
(i.e. Regeneration activity, etc.)? no
How should this be tested?
Without this PR:
drush cex --diff
. You should see that the media URLs have been set to True.With this PR:
drush cex --diff
should not include this, because the value wasn't set in a way that contradicts the starter site.Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers