Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable bartik. #259

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Feb 27, 2023

GitHub Issue: addresses part of #248

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Doesn't enable bartik, since defaults is no longer being installed. When it gets installed, there are a number of Bartik blocks added to the starter site's config suite, which is bad.

What's new?

  • Don't enable bartik.
  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? If you are requiring bartik to be enabled, make sure you do it somewhere.

How should this be tested?

Before:

  • load the starter site. Load a config or two in the UI.
  • Export configs. Note that a lot of blocks were added to the configs.
    After:
  • load the starter site. Load some configs in the UI.
  • Export configs. No bartik blocks should be added to the configs.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

Copy link
Contributor

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 🔥 bartik.

@seth-shaw-asu seth-shaw-asu merged commit 06831fa into Islandora-Devops:dev Mar 1, 2023
@rosiel rosiel deleted the no-bartik branch March 2, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants