Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced small .env change and docker-compose.override.yml #214

Closed
wants to merge 1 commit into from

Conversation

McFateM
Copy link
Member

@McFateM McFateM commented Mar 28, 2019

I've been doing extensive testing of ISLE v1.1 requiring frequent changes to docker-compose.yml. Lately I've started using the override feature of docker-compose and suggest adoption of this feature in ISLE going forward. The capabilities of this feature are documented at https://docs.docker.com/compose/extends/.

This PR added a very small addition to the existing .env file, and takes advantage of that addition by introducing a new docker-compose.override.yml file into the stack.

@bseeger
Copy link
Contributor

bseeger commented Mar 29, 2019

Hi Mark, by putting the override file there, it automatically makes it be used, right? Are you suggesting that this be the canonical way to use ISLE? Will all users want the changes you've made to this file?

What I'm wondering is if we want it in there as an option, but not active unless people chose to make it active.

@McFateM
Copy link
Member Author

McFateM commented Mar 29, 2019 via email

@McFateM
Copy link
Member Author

McFateM commented Mar 31, 2019

OK, I'd like to close this PR in favor of a little different approach that I think may be easier to manage and document. See Issue #216 for details.

@McFateM McFateM closed this Mar 31, 2019
@bseeger bseeger deleted the override.yml branch September 11, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants