Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test upgrading ironoxide #230

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Test upgrading ironoxide #230

merged 12 commits into from
Oct 31, 2024

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Oct 24, 2024

No description provided.

coltfred
coltfred requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we can't use DeviceContext (due to this API not supporting async), I think we should instead use the DeviceContext name to point to the BlockingDeviceContext from Rust.

@giarc3 giarc3 marked this pull request as ready for review October 29, 2024 21:48
@giarc3 giarc3 requested a review from coltfred October 29, 2024 22:50
@giarc3 giarc3 merged commit ac406bf into main Oct 31, 2024
13 checks passed
@giarc3 giarc3 deleted the test-ironoxide-upgrade branch October 31, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltfred coltfred coltfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giarc3 @coltfred