Merge branch 'lasselehtinen-master'

Intervention · Dec 9, 2023 · d3ab528 · d3ab528
2 parents c0af56c + 77b9a93
commit d3ab528
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Rules/Isbn.php b/src/Rules/Isbn.php
@@ -36,8 +36,8 @@ public function passes($attribute, $value)
             case 10:
                 return $this->shortChecksumMatches($value);
 
-            case 13:
-                return parent::checksumMatches($value); // isbn-13 is a subset of ean-13
+            case 13: // isbn-13 is a subset of ean-13
+                return preg_match("/^(978|979)/", $value) && parent::checksumMatches($value);
         }
 
         return false;

diff --git a/tests/Rules/IsbnTest.php b/tests/Rules/IsbnTest.php
@@ -69,6 +69,7 @@ public function dataProvider()
             [false, 'ABC'],
             [false, '978-0-306-40615-6'],
             [false, '99921-58-10-6'],
+            [false, '0123456789012'],
         ];
     }
 
@@ -122,6 +123,7 @@ public function dataProviderLong()
             [false, 'ABC'],
             [false, '978-0-306-40615-6'],
             [false, '99921-58-10-6'],
+            [false, '0123456789012'],
         ];
     }
-}
+}