-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate cardano-ledger
releases
#1345
base: main
Are you sure you want to change the base?
Conversation
0212c01
to
e562637
Compare
e562637
to
7564107
Compare
7564107
to
9054f1a
Compare
9054f1a
to
e47f737
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the PR, but please take care of the two comments I left.
@@ -278,7 +278,7 @@ library | |||
bytestring >=0.10 && <0.13, | |||
cardano-binary, | |||
cardano-crypto-class, | |||
cardano-ledger-core ^>=1.15, | |||
cardano-ledger-core >=1.15, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not constrain it to ^>=1.16
?
@@ -119,7 +119,7 @@ test-suite protocol-test | |||
base, | |||
cardano-crypto-class, | |||
cardano-ledger-binary:testlib, | |||
cardano-ledger-core, | |||
cardano-ledger-core >=1.16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ^>=1.16
.
Integrate the changes in new versions that
cardano-ledger
recently added to CHaP