Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cardano-ledger releases #1345

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

neilmayhew
Copy link

Integrate the changes in new versions that cardano-ledger recently added to CHaP

@neilmayhew neilmayhew force-pushed the neilmayhew/integrate-ledger branch from 0212c01 to e562637 Compare December 18, 2024 21:25
@neilmayhew neilmayhew force-pushed the neilmayhew/integrate-ledger branch from e562637 to 7564107 Compare December 18, 2024 21:26
@neilmayhew neilmayhew marked this pull request as ready for review December 18, 2024 21:26
@neilmayhew neilmayhew force-pushed the neilmayhew/integrate-ledger branch from 7564107 to 9054f1a Compare December 18, 2024 22:52
@neilmayhew neilmayhew force-pushed the neilmayhew/integrate-ledger branch from 9054f1a to e47f737 Compare December 18, 2024 23:14
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the PR, but please take care of the two comments I left.

@@ -278,7 +278,7 @@ library
bytestring >=0.10 && <0.13,
cardano-binary,
cardano-crypto-class,
cardano-ledger-core ^>=1.15,
cardano-ledger-core >=1.15,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not constrain it to ^>=1.16?

@@ -119,7 +119,7 @@ test-suite protocol-test
base,
cardano-crypto-class,
cardano-ledger-binary:testlib,
cardano-ledger-core,
cardano-ledger-core >=1.16,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ^>=1.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants