Add support for measures to LocalTxMonitor #1191
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
nfrisby
force-pushed
the
nfrisby/consolidate-txlimits
branch
2 times, most recently
from
3661dcc to
4ea4ab8
Compare
Remove `Mempool.`getTxSize`; the snapshot interface contains sizes now. Transaction size, block capacity, and mempool capacity are multi-dimensional vectors (incl ExUnits, etc), instead of merely bytes: see `TxMeasure`. A transaction cannot be added if it would push any component of the size over that component's capacity. The capacity override is still only specified in byte size, but the value is interpreted as a block count (rounded up). Enforce block capacity _before_ the forging logic. Now the forging logic simply includes whatever transactions its given, which is reasonable and simpler. It's the NodeKernel logic that uses the mempool's finger tree in order to slice an appropriately-sized prefix, which is then passed to the now-dumb forging function. consensus: no longer need BoundedMeasure, Measure suffices consensus-cardano: use ConwayMeasure in Babbage TOSQUASH fixup overflow workarounds and their explanations consensus: update stale tryAddTxs Haddock references consensus: an editing pass on the addTx Haddock consensus: elaborate comment on pureTryAddTx guard consensus: mitigate new mempool DoS vector consensus: txMeasure now fails if the tx is too big TOSQUASH fixup hlint and 9.* build TOSQUASH fixup stylish TOSQUASH polishing consensus: explicit overflow check in pureTryAddTx consensus: Word32 for tx byte size instead of Natural consensus: mention Segregated Witness scheme in tx byte size comment
nfrisby
force-pushed
the
nfrisby/consolidate-txlimits
branch
from
4ea4ab8 to
ee1400e
Compare
nfrisby
force-pushed
the
nfrisby/consolidate-txlimits
branch
from
f15f603 to
a7bd1c5
Compare
…will likely explode due to overflow
fraser-iohk
force-pushed
the
fraser-iohk/localtxmonitor-measures
branch
from
16e7267 to
159d33f
Compare
nfrisby
force-pushed
the
nfrisby/consolidate-txlimits
branch
6 times, most recently
from
6ad371d to
9c022f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1178 and builds on #1175 by adding support for arbitrary measures to the
LocalTxMonitorserver inouroboros-consensus. Relevant changes toouroboros-networkare required to build these changes, since theLocalTxMonitorprotocol has been changed to add a newGetMeasuresmessage.Remaining work required before this can be merged:
ouroboros-networkPR needs to be mergeddeal withfromByteSizebeing very likely to silently overflow the new numeric type