Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 API Allows Multiple Votes on the Same Proposal Poll #2356

Open
kneerose opened this issue Nov 8, 2024 · 3 comments
Open

🐛 API Allows Multiple Votes on the Same Proposal Poll #2356

kneerose opened this issue Nov 8, 2024 · 3 comments
Assignees
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar

Comments

@kneerose
Copy link
Contributor

kneerose commented Nov 8, 2024

Area

Proposal Pillar

Domain

dev-sanchogov.tools

Which wallet were you using?

No response

Context

Users can submit multiple votes on the same proposal poll through CURL, bypassing UI restrictions.

Steps to reproduce

  1. Connect to the wallet.
  2. Navigate to any proposal with a poll. (eg : https://dev-sanchonet.govtool.byron.network/proposal_discussion/2061)
  3. Submit a vote on the poll.
  4. Copy the network request for the vote as a CURL command.
  5. Paste and execute the CURL command in the terminal.
  6. Observe that the same proposal can be voted on multiple times using this method.

Actual behavior

The API accepts multiple votes on the same proposal when submitted through CURL, even though the UI prevents duplicate submissions.

https://www.loom.com/share/c05063dca7c1496f9a5905ea7dacc3c0?sid=ca3933e2-fc00-41d3-a61f-08d34f63f3c2

Expected behavior

The API should reject multiple votes on the same proposal when using the same authentication.

@kneerose kneerose added the 🐛 Bug Something isn't working label Nov 8, 2024
@kneerose kneerose changed the title 🐛 API Allows Multiple Votes on the Same Proposal Poll via CURL 🐛 API Allows Multiple Votes on the Same Proposal Poll Nov 8, 2024
@bosko-m bosko-m moved this to To do in Govtool all Nov 8, 2024
@nebojsajsimic nebojsajsimic moved this from To do to In progress in Govtool all Nov 12, 2024
@nebojsajsimic nebojsajsimic moved this from In progress to In QA in Govtool all Nov 12, 2024
@nebojsajsimic
Copy link

This issue is fixed, after deployment you can test

@kneerose
Copy link
Contributor Author

@nebojsajsimic I was unable to test it. Did the backend go down? Also i am unable to verify my identity.
image
Screenshot from 2024-11-13 09-33-16

@bosko-m bosko-m moved this from In QA to In review in Govtool all Nov 18, 2024
@kneerose
Copy link
Contributor Author

CC: @bosko-m
Based on the provided response, the issue now appears to be resolved.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar
Projects
Status: No status
Status: In review
Development

No branches or pull requests

3 participants