Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Supporting space on Given name #2276

Closed
spannercode opened this issue Oct 30, 2024 · 7 comments · Fixed by #2343
Closed

🐛 Supporting space on Given name #2276

spannercode opened this issue Oct 30, 2024 · 7 comments · Fixed by #2343
Assignees
Labels

Comments

@spannercode
Copy link
Contributor

Area

Delegation Pillar

Domain

gov.tools

Which wallet were you using?

N/A

Context

As a DRep I should be able to set my Given Name with multiple words separated by space.

givenName (link)

- Compulsory
- This is a property inherited from [Person](https://schema.org/Person)
- It is the only compulsory property
- A very short freeform text field. Limited to 80 characters.
- This MUST NOT support markdown text styling.
- It is intended that authors will use this field for their profile name/ username.

There was a misunderstanding on the requirement here leading to not allowing the spaces:
#1873

Steps to reproduce

While registering as DRep or editing DRep metadata, try to input given name with space.

Actual behavior

Space and multiple words separated by space is not allowed

Expected behavior

Space and multiple words should be supported.

@m-i-k-e
Copy link

m-i-k-e commented Oct 30, 2024

There are lots of spaces in Unicode:
https://www.compart.com/en/unicode/category/Zs

Question: do we allow just one space, and what about consecutive spaces? All Unicode characters, or just one of them?

Could a user make a name up of just spaces? It would seem acceptable under the rules.

@bosko-m
Copy link
Contributor

bosko-m commented Nov 3, 2024

For the start we should just allow space character , ascii code 32.

@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Nov 6, 2024
@MSzalowski MSzalowski linked a pull request Nov 6, 2024 that will close this issue
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Nov 6, 2024
MSzalowski added a commit that referenced this issue Nov 7, 2024
…e-on-given-name

feat(#2276): add support for space in given name
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Nov 7, 2024
@kneerose
Copy link
Contributor

kneerose commented Nov 8, 2024

@bosko-m Still reproducing on dev , preview env

Allure report on preview

@kneerose kneerose reopened this Nov 8, 2024
@bosko-m
Copy link
Contributor

bosko-m commented Nov 8, 2024

@kneerose Its not yet deployed on preview.

@kneerose
Copy link
Contributor

kneerose commented Nov 8, 2024

@bosko-m still reproducing on dev
image

@bosko-m bosko-m moved this from Done to In progress in Govtool all Nov 8, 2024
@MSzalowski
Copy link
Contributor

Zrzut ekranu z 2024-11-08 12-27-30

Could you please recheck this? It seems to be working just fine now

@MSzalowski MSzalowski moved this from In progress to Done in Govtool all Nov 8, 2024
@bosko-m
Copy link
Contributor

bosko-m commented Nov 14, 2024

Verified on Preview.

@bosko-m bosko-m closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants