Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardano-node after addition of the new BulkSync implementation #5942

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

TOSQUASH improve GDD tracing

b1373e9
Select commit
Loading
Failed to load commit list.
Draft

Update cardano-node after addition of the new BulkSync implementation #5942

TOSQUASH improve GDD tracing
b1373e9
Select commit
Loading
Failed to load commit list.
IOG Hydra / ci/hydra-build:x86_64-linux.native.checks/hlint failed Sep 10, 2024 in 55s

Build failed

1 failed steps

Details

Failed Steps

Step 1

Derivation

/nix/store/h0kzfm8rnravhy3x1wvz3dqm4cwhkpl6-hlint-check.drv

Log

cardano-node/src/Cardano/Node/Run.hs:9:1-35: Warning: Unused LANGUAGE pragma
Found:
  {-# LANGUAGE NumericUnderscores #-}
Perhaps you should remove it.

cardano-node/src/Cardano/Node/Run.hs:15:1-33: Warning: Use fewer LANGUAGE pragmas
Found:
  {-# LANGUAGE TypeApplications #-}
  {-# LANGUAGE TypeApplications #-}
  
Perhaps:
  {-# LANGUAGE TypeApplications #-}

cardano-node/src/Cardano/Node/Run.hs:882:39-42: Suggestion: Use underscore
Found:
  3300
Perhaps:
  3_300

cardano-node/src/Cardano/Node/Tracing/Tracers/Consensus.hs:850:15-47: Suggestion: Move brackets to avoid $
Found:
  "start" .= (String $ showT start)
Perhaps:
  "start" .= String (showT start)

cardano-node/src/Cardano/Node/Tracing/Tracers/Consensus.hs:851:15-43: Suggestion: Move brackets to avoid $
Found:
  "end" .= (String $ showT end)
Perhaps:
  "end" .= String (showT end)

5 hints
=====================================================================
Note: to ignore a particular hint (e.g. "Reduce duplication"), write
this in the source file:
{-# ANN module ("HLint: ignore Reduce duplication" :: Text) #-}
You can also apply it just to a particular function, which is better:
{-# ANN funcName ("HLint: ignore Reduce duplication" :: Text) #-}