Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate the Protection of the "releases" Folder #266

Closed
wants to merge 1 commit into from

Conversation

sebbader-sap
Copy link
Contributor

#264 requires an update of the files in "releases/2024-1/", which is protected by a Github Action. This PR shall temporarily remove the protection to fix the files. A following PR will then re-enable the Action again.

@sebbader-sap sebbader-sap requested a review from juliapampus May 21, 2024 12:21
@sebbader-sap sebbader-sap marked this pull request as ready for review May 21, 2024 12:22
@sebbader-sap
Copy link
Contributor Author

@juliapampus I assume that commenting out line 5 of the Action does the job. Can you have a look?

@mkollenstart
Copy link
Member

I don't think it is necessary to disable the check via the repository (and actually the change doesn't disable it as it actually will apply to all pull requests now and not only to main).

I think @ssteinbuss can temporarily update the settings of the repository itself via rulesets.

@sebbader-sap
Copy link
Contributor Author

@ssteinbuss please have a look here. Can you check Maarten's proposal with the rulesets?

@sebbader-sap
Copy link
Contributor Author

as #264 is merged, this PR is not needed anymore

@sebbader-sap sebbader-sap deleted the deactivate-release-folder-protection branch June 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants