Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Dispose method on IntersectionObserver to reference this.element #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes Dispose method on IntersectionObserver to reference this.element #24

wants to merge 1 commit into from

Conversation

ecammit
Copy link

@ecammit ecammit commented Aug 15, 2023 •
edited
Loading

Prevents runtime errors during a dispose call of Uncaught ReferenceError: element is not defined

Resolved #23

@ecammit
Fix dispose method on IntersectionObserver technique to reference thi…
be8b5c2 
…s.element and prevent runtime errors during a dispose call. Reference: Issue InteractiveAdvertisingBureau#23
@ecammit
Copy link
Author

ecammit commented Jan 30, 2024

@iabshailley
@goosemanjack
@vladgurgov
@jdreetz

If any of you still have access to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dispose references element instead of this.element
1 participant
@ecammit