Fix dispose method on IntersectionObserver technique to reference thi…

…s.element and prevent runtime errors during a dispose call. Reference: Issue #23
InteractiveAdvertisingBureau · Aug 15, 2023 · be8b5c2 · be8b5c2
1 parent 3c2bc36
commit be8b5c2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/demo/vpaid/vpaid-client.js b/demo/vpaid/vpaid-client.js
@@ -1619,8 +1619,8 @@ var IntersectionObserver = function (_BaseTechnique) {
     key: 'dispose',
     value: function dispose() {
       if (this.observer) {
-        this.observer.unobserve(element);
-        this.observer.disconnect(element);
+        this.observer.unobserve(this.element);
+        this.observer.disconnect(this.element);
       }
     }
 

diff --git a/dist/openvv.js b/dist/openvv.js
diff --git a/src/Measurement/MeasurementTechniques/IntersectionObserver.js b/src/Measurement/MeasurementTechniques/IntersectionObserver.js
@@ -46,8 +46,8 @@ export default class IntersectionObserver extends BaseTechnique {
    */
   dispose() {
     if(this.observer) {
-      this.observer.unobserve(element);
-      this.observer.disconnect(element);
+      this.observer.unobserve(this.element);
+      this.observer.disconnect(this.element);
     }
   }
 
@@ -106,4 +106,4 @@ export default class IntersectionObserver extends BaseTechnique {
     }
   }
 
-}
+}