Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an email for newly enrolled members #800

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

supertom01
Copy link
Member

Please add the following information to your pull request:

Please describe what your PR is fixing
When a new member is enrolled, they will receive an email.

Concretely, which issues does your PR solve? (Please reference them by typing Fixes/References Inter-Actief/amelie#<issue_id>)
Fixes #720

Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no

Does your PR include any django migrations?
no

Does your PR include the proper translations (did you add translations for new/modified strings)?
yes, however after the email template has been updated the translations should be added

Does your PR include CSS changes (and did you run the compile_css.sh script in the scripts directory to regenerate the compiled.css file)?
no, my PR does not include CSS changes

Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no

Did you properly test your PR before submitting it?
no, testing the entire mail system is quite hard due to the need to enroll members and finalize all of the steps. This feature has only been tested for creating external members.

@supertom01
Copy link
Member Author

@[email protected] @SimplyPancake asked me to let you write the invitation email. You should be able to find the template for it within new_member.mail. Please let me know when you've updated it (and provide a dutch translation too :))

@supertom01 supertom01 marked this pull request as draft October 2, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mailing when person becomes a member
1 participant