Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug in logic on listing 5.20 #772

Merged

Conversation

BenjaminMichaelis
Copy link
Member

@BenjaminMichaelis BenjaminMichaelis commented Mar 28, 2024

Fixes #728

By happenstance of default value being 0 and that being the value of Black, test was passing. Changed to yellow to make it clear that this failed

@BenjaminMichaelis BenjaminMichaelis self-assigned this Mar 28, 2024
@BenjaminMichaelis BenjaminMichaelis linked an issue Mar 28, 2024 that may be closed by this pull request
@BenjaminMichaelis BenjaminMichaelis requested a review from Keboo March 28, 2024 03:46
@BenjaminMichaelis BenjaminMichaelis force-pushed the 728-listing0520-returning-a-reference-source-code branch from 51940b3 to 92b6a23 Compare April 4, 2024 02:16
@BenjaminMichaelis BenjaminMichaelis force-pushed the 728-listing0520-returning-a-reference-source-code branch from 92b6a23 to c8ac032 Compare April 4, 2024 02:17
@BenjaminMichaelis BenjaminMichaelis enabled auto-merge (squash) April 4, 2024 02:17
@BenjaminMichaelis BenjaminMichaelis merged commit 027b36e into v12.0 Apr 4, 2024
6 checks passed
@BenjaminMichaelis BenjaminMichaelis deleted the 728-listing0520-returning-a-reference-source-code branch April 4, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing05.20 Returning A Reference (source code)
2 participants