Test rules in pyflakes directory
#271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Mar 8, 2023
facebook-github-bot
added
the
CLA Signed
amyreese
requested changes
Mar 8, 2023
| @@ -72,7 +72,7 @@ version-file = "src/fixit/__version__.py" | |||
| features = ["dev", "pretty"] | |||
|
|
|||
| [tool.hatch.envs.default.scripts] | |||
| test = "python -m fixit.tests" | |||
| test = "python3 -m fixit.tests" | |||
There was a problem hiding this comment.
Why was this change needed? Hatch environments should be controlled enough that just python will always work.
There was a problem hiding this comment.
I think this being "python3" is what's causing the CI failures on windows. My guess is that the virtualenv doesn't have a python3.exe in it, and so it's finding a random non-venv runtime, and therefore can't find/import fixit.
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
pyflakesdirectory #271