Skip to content

Commit

Permalink
Fix example is_selected
Browse files Browse the repository at this point in the history
  • Loading branch information
Insality committed Oct 22, 2024
1 parent 7aa24db commit aff4412
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
14 changes: 0 additions & 14 deletions docs_md/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -574,17 +574,3 @@ And all my other supporters! Very appreciated!
Please support me if you like this project! It will help me keep engaged to update **Druid** and make it even better!

[![Github-sponsors](https://img.shields.io/badge/sponsor-30363D?style=for-the-badge&logo=GitHub-Sponsors&logoColor=#EA4AAA)](https://github.com/sponsors/insality) [![Ko-Fi](https://img.shields.io/badge/Ko--fi-F16061?style=for-the-badge&logo=ko-fi&logoColor=white)](https://ko-fi.com/insality) [![BuyMeACoffee](https://img.shields.io/badge/Buy%20Me%20a%20Coffee-ffdd00?style=for-the-badge&logo=buy-me-a-coffee&logoColor=black)](https://www.buymeacoffee.com/insality)


---

**Postmortem**

Thoughts, wrong decisions, future plans, and how to update correctly:

- No styles should exist.
- Annotations should be updated or removed.
- Non-explicit event parameters can cause confusion, particularly with `self` parameters.
- There is room for performance optimization. Memory usage is not optimized, though it can still handle heavy-load GUIs like Panthera.
- Creating custom components could be made easier.
- There can be a much less code bindings between elements. Like bind_grid, update_size after some changes etc.
2 changes: 1 addition & 1 deletion example/druid.gui_script
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ local function select_start_example(self)
-- Try load example from URL
local example_name = html5.run("new URLSearchParams(window.location.search).get('example')")
if example_name then
local is_selected self.examples_list_view:select_example_by_name_id(example_name)
local is_selected = self.examples_list_view:select_example_by_name_id(example_name)
if is_selected then
return
end
Expand Down

0 comments on commit aff4412

Please sign in to comment.