Modern cmake (no include_directories)

[nebatmusic]

STEPS TO MOVE TO MODERN CMAKE.

First rule : do not include_directories

[mathildemerle]

This seems to be an example of PR that needs to be done on medInria, as we said last meeting

[nebatmusic]

This seems to be an example of PR that needs to be done on medInria, as we said last meeting

needs also to be done you mean.
Like #659.

[nebatmusic]

Moder CMAKE. Think in term of modules. Keeps your flags to yourself
WIP illustation.

[nebatmusic]

This seems to be an example of PR that needs to be done on medInria, as we said last meeting

needs also to be done you mean.
Like #659.

This is an improvement of the PR done on medinria public medInria#610 . But in this PR they were some errors.
For example It did not follow the rule 2 : "never do a target_include_directories on a directory outside of your project"

[mathildemerle]

#659 is mandatory for MUSICardio, not medInria, this is a change in the minimal number of cmake. However, as far as i see, this PR should be done on medInria. You can talk about that to FlorentL

[nebatmusic]

#659 is mandatory for MUSICardio, not medInria, this is a change in the minimal number of cmake. However, as far as i see, this PR should be done on medInria. You can talk about that to FlorentL

Ok. But it is in medInria3.2.x.

[Florent2305]

It's a Huge change for medInria3.2 but this PR contains some good changes.
Then maybe it's a good idea to propose this pr for medInria master (4.0)

[nebatmusic]

It's a Huge change for medInria3.2 but this PR contains some good changes.
Then maybe it's a good idea to propose this pr for medInria master (4.0)

I do not agree. It is minor change in some package generation files for legacy code in order to follow modern cmake modern already available in medinria. It doesn't break any API. I think that changes that should be in 4 are those breaking some API (rule that I have heard a few days ago about LIB versioning).

[nebatmusic]

What should be done in 4, is to tell HASTA LA VISTA to legacy code (I want to say update it of course).