Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/Inhabas#228] 공모전 게시판 API 구현 #230

Merged
merged 50 commits into from
Mar 2, 2024
Merged

[feature/Inhabas#228] 공모전 게시판 API 구현 #230

merged 50 commits into from
Mar 2, 2024

Conversation

skytin1004
Copy link
Member

No description provided.

@skytin1004 skytin1004 requested a review from whitem4rk February 2, 2024 02:17
@skytin1004 skytin1004 changed the title Contest board [feature/Inhabas#228] 공모전 게시판 API 구현 Feb 2, 2024
@skytin1004 skytin1004 self-assigned this Feb 2, 2024
@skytin1004 skytin1004 added the new feature New feature or request label Feb 2, 2024
whitem4rk
whitem4rk reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@whitem4rk whitem4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제가 될 만한 코드는 없었습니다.

resource-server/src/main/java/com/inhabas/api/domain/contest/domain/ContestBoard.java Show resolved Hide resolved
...rce-server/src/main/java/com/inhabas/api/domain/contest/usecase/ContestBoardServiceImpl.java Outdated Show resolved Hide resolved
resource-server/src/main/java/com/inhabas/api/web/ContestBoardController.java Outdated Show resolved Hide resolved
resource-server/src/main/java/com/inhabas/api/web/ContestBoardController.java Outdated Show resolved Hide resolved
@whitem4rk
Copy link
Contributor

이대로 구현 계속하면 될 것 같습니다.

@skytin1004
Copy link
Member Author

에러 코드 정리 필요

@skytin1004 skytin1004 marked this pull request as ready for review February 24, 2024 01:13
whitem4rk
whitem4rk reviewed Feb 24, 2024
View reviewed changes
resource-server/src/main/java/com/inhabas/api/domain/contest/domain/ContestBoard.java Show resolved Hide resolved
resource-server/src/main/java/com/inhabas/api/domain/contest/domain/ContestField.java Outdated Show resolved Hide resolved
resource-server/src/main/java/com/inhabas/api/domain/contest/domain/valueObject/Topic.java Outdated Show resolved Hide resolved
resource-server/src/main/java/com/inhabas/api/domain/contest/domain/ContestBoard.java Show resolved Hide resolved
...rver/src/main/java/com/inhabas/api/domain/contest/repository/ContestBoardRepositoryImpl.java Outdated Show resolved Hide resolved
...er/src/main/java/com/inhabas/api/domain/contest/repository/ContestBoardRepositoryCustom.java Outdated Show resolved Hide resolved
...rce-server/src/main/java/com/inhabas/api/domain/contest/usecase/ContestBoardServiceImpl.java Outdated Show resolved Hide resolved
resource-server/src/main/java/com/inhabas/api/web/ContestBoardController.java Outdated Show resolved Hide resolved
@skytin1004 skytin1004 merged commit 9412373 into InhaBas:master Mar 2, 2024
2 checks passed
@skytin1004 skytin1004 deleted the contest-board branch March 4, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitem4rk whitem4rk whitem4rk approved these changes

Assignees

@skytin1004 skytin1004

Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skytin1004 @whitem4rk