[Refactor/#164] Member, Security 개편 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JdbcOAuth2AuthorizedClientService
…연관 test code 임시 수정
whitem4rk
temporarily deployed
to
build_gradle
GitHub Actions
Inactive
whitem4rk
changed the title
skytin1004
reviewed
Nov 25, 2023
| @@ -78,7 +81,8 @@ project(':module-jpa') { | |||
| 'org.springframework.boot:spring-boot-starter-data-jpa', | |||
| 'com.querydsl:querydsl-jpa', // query dsl | |||
| 'com.jcraft:jsch:0.1.55', // 로컬 개발용 db ssh tunneling, https://mavenlibs.com/maven/dependency/com.jcraft/jsch | |||
| 'org.mariadb.jdbc:mariadb-java-client', | |||
| // 'org.mariadb.jdbc:mariadb-java-client', | |||
| 'mysql:mysql-connector-java', | |||
...main/java/com/inhabas/api/auth/domain/oauth2/handler/Oauth2AuthenticationSuccessHandler.java
Show resolved
Hide resolved
|
|
||
|
|
||
| } | ||
| //package com.inhabas.api.auth.domain.token; |
There was a problem hiding this comment.
이거 테스트 통과가 안되나요?! 주석 처리한 이유를 알고싶습니다.
There was a problem hiding this comment.
이 클래스가 사라지고 다른 비슷한 기능을 하는 클래스를 만들었어. 그래서 지울까 하다가 나중에 테스트코드 작성할때 사용하려고 놔둔거야
...-server/src/test/java/com/inhabas/api/domain/board/repository/NormalBoardRepositoryTest.java
Show resolved
Hide resolved
whitem4rk
temporarily deployed
to
build_gradle
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
좀 더 체계적으로 나누어서 브랜치를 파고 MERGE 했어야 했는데 그러지 못했음...
앞으로는 squash merge 방식으로 PR해 나갈예정
가장 큰 문제는 TABLE을 수정하고 하다 보니 현재 PRODUCTION 데이터를 손실없이 어떻게 잘 가져와서 사용할 수 있을지 모르겠음.