[bugfix/#326] 회계내역 작성에 memberId 추가

InhaBas · Jun 28, 2024 · 5b9efdf · 5b9efdf
1 parent dd62793
commit 5b9efdf
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/resource-server/src/main/java/com/inhabas/api/domain/budget/dto/BudgetHistoryCreateForm.java b/resource-server/src/main/java/com/inhabas/api/domain/budget/dto/BudgetHistoryCreateForm.java
@@ -35,6 +35,8 @@ public class BudgetHistoryCreateForm {
 
   @NotBlank private String details;
 
+  private Long memberIdReceived;
+
   private String memberStudentIdReceived;
 
   private String memberNameReceived;
@@ -54,6 +56,7 @@ public BudgetHistoryCreateForm(
       LocalDateTime dateUsed,
       String title,
       String details,
+      Long memberIdReceived,
       String memberStudentIdReceived,
       String memberNameReceived,
       Integer income,
@@ -62,6 +65,7 @@ public BudgetHistoryCreateForm(
     this.dateUsed = dateUsed;
     this.title = title;
     this.details = details;
+    this.memberIdReceived = memberIdReceived;
     this.memberStudentIdReceived = memberStudentIdReceived;
     this.memberNameReceived = memberNameReceived;
     this.income = income;
@@ -75,13 +79,15 @@ public BudgetHistoryCreateForm(
   public boolean isIncome() {
     return this.income > ZERO
         && this.outcome == 0
+        && this.memberIdReceived == null
         && this.memberNameReceived == null
         && this.memberStudentIdReceived == null;
   }
 
   public boolean isOutcome() {
     return this.outcome > ZERO
         && this.income == 0
+        && this.memberIdReceived != null
         && this.memberNameReceived != null
         && this.memberStudentIdReceived != null;
   }

diff --git a/...-server/src/main/java/com/inhabas/api/domain/budget/usecase/BudgetHistoryServiceImpl.java b/...-server/src/main/java/com/inhabas/api/domain/budget/usecase/BudgetHistoryServiceImpl.java
@@ -47,8 +47,10 @@ public Long createHistory(BudgetHistoryCreateForm form, Long secretaryId) {
     } else if (form.isOutcome()) {
       memberReceived =
           memberRepository
-              .findByStudentId_IdAndName_Value(
-                  form.getMemberStudentIdReceived(), form.getMemberNameReceived())
+              .findByIdAndStudentId_IdAndName_Value(
+                  form.getMemberIdReceived(),
+                  form.getMemberStudentIdReceived(),
+                  form.getMemberNameReceived())
               .orElseThrow(MemberNotFoundException::new);
     } else {
       throw new InvalidInputException();
@@ -79,8 +81,10 @@ public void modifyHistory(Long historyId, BudgetHistoryCreateForm form, Long sec
     } else if (form.isOutcome()) {
       memberReceived =
           memberRepository
-              .findByStudentId_IdAndName_Value(
-                  form.getMemberStudentIdReceived(), form.getMemberNameReceived())
+              .findByIdAndStudentId_IdAndName_Value(
+                  form.getMemberIdReceived(),
+                  form.getMemberStudentIdReceived(),
+                  form.getMemberNameReceived())
               .orElseThrow(MemberNotFoundException::new);
     } else {
       throw new InvalidInputException();

diff --git a/...-server/src/test/java/com/inhabas/api/domain/budget/usecase/BudgetHistoryServiceTest.java b/...-server/src/test/java/com/inhabas/api/domain/budget/usecase/BudgetHistoryServiceTest.java
@@ -105,6 +105,7 @@ public void createOutcomeHistoryTest() {
             .dateUsed(LocalDateTime.now())
             .title("title")
             .details("details")
+            .memberIdReceived(1L)
             .memberStudentIdReceived("12171707")
             .memberNameReceived("조승현")
             .income(0)
@@ -125,7 +126,7 @@ public void createOutcomeHistoryTest() {
             .build();
 
     given(memberRepository.findById(any())).willReturn(Optional.of(secretary));
-    given(memberRepository.findByStudentId_IdAndName_Value(any(), any()))
+    given(memberRepository.findByIdAndStudentId_IdAndName_Value(any(), any(), any()))
         .willReturn(Optional.of(memberReceived));
     given(menuRepository.findById(anyInt())).willReturn(Optional.of(menu));
     given(boardFileRepository.getAllByIdInAndUploader(anyList(), any())).willReturn(List.of(file));
@@ -153,6 +154,7 @@ public void modifyHistoryTest() {
             LocalDateTime.now().minusDays(1L),
             "title",
             "details",
+            1L,
             "12171234",
             "유동현",
             0,
@@ -173,7 +175,7 @@ public void modifyHistoryTest() {
             .writtenBy(secretary, BudgetHistory.class);
     ReflectionTestUtils.setField(budgetHistory, "id", 1L);
     given(memberRepository.findById(any())).willReturn(Optional.of(secretary));
-    given(memberRepository.findByStudentId_IdAndName_Value(any(), any()))
+    given(memberRepository.findByIdAndStudentId_IdAndName_Value(any(), any(), any()))
         .willReturn(Optional.of(memberReceived));
     given(budgetHistoryRepository.findById(any())).willReturn(Optional.of(budgetHistory));
     given(boardFileRepository.getAllByIdInAndUploader(anyList(), any())).willReturn(List.of(file));