feat: add get niscode by validFrom date

BREAKING CHANGE: Added method INisCodeService
Informatievlaanderen · Nov 4, 2024 · f244cc9 · f244cc9
1 parent d09ec30
commit f244cc9
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/paket.dependencies b/paket.dependencies
@@ -13,7 +13,7 @@ nuget Newtonsoft.Json 13.0.3
 
 // VBR STUFF
 nuget Be.Vlaanderen.Basisregisters.Build.Pipeline 7.0.4 strategy:max
-nuget Be.Vlaanderen.Basisregisters.DockerUtilities 2.0.0
+nuget Be.Vlaanderen.Basisregisters.DockerUtilities 3.0.0
 nuget Be.Vlaanderen.Basisregisters.Aws.DistributedMutex 4.0.1
 
 // TEST STUFF

diff --git a/src/NisCodeService.Abstractions/INisCodeService.cs b/src/NisCodeService.Abstractions/INisCodeService.cs
@@ -4,9 +4,12 @@
 
 namespace NisCodeService.Abstractions
 {
+    using System;
+
     public interface INisCodeService
     {
         Task<Dictionary<string, string>> GetAll(CancellationToken cancellationToken = default);
         Task<string?> Get(string ovoCode, CancellationToken cancellationToken = default);
+        Task<string?> Get(string ovoCode, DateTime validFrom, CancellationToken cancellationToken = default);
     }
 }
diff --git a/src/NisCodeService.DynamoDb/DynamoDbNisCodeService.cs b/src/NisCodeService.DynamoDb/DynamoDbNisCodeService.cs
@@ -1,5 +1,6 @@
 namespace NisCodeService.DynamoDb
 {
+    using System;
     using System.Collections.Generic;
     using System.Linq;
     using System.Threading;
@@ -54,5 +55,10 @@ public async Task<Dictionary<string, string>> GetAll(CancellationToken cancellat
             var response = await _amazonDynamoDb.GetItemAsync(query, cancellationToken);
             return response.Item?.GetValueOrDefault(ColumnNames.NisCode)?.S;
         }
+
+        public Task<string?> Get(string ovoCode, DateTime validFrom, CancellationToken cancellationToken = default)
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/src/NisCodeService.HardCoded/HardCodedNisCodeService.cs b/src/NisCodeService.HardCoded/HardCodedNisCodeService.cs
@@ -38,5 +38,12 @@ public Task<Dictionary<string, string>> GetAll(CancellationToken cancellationTok
 
             return Task.FromResult(nisCodes?.SingleOrDefault(x => x.IsValid(DateTime.Now))?.NisCode);
         }
+
+        public Task<string?> Get(string ovoCode, DateTime validFrom, CancellationToken cancellationToken = default)
+        {
+            _allNisCodeByOvoCodes.TryGetValue(ovoCode, out var nisCodes);
+
+            return Task.FromResult(nisCodes?.SingleOrDefault(x => x.IsValid(validFrom))?.NisCode);
+        }
     }
 }