Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename FlightSQL constant to SQL #71

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

bednar
Copy link
Member

@bednar bednar commented Mar 27, 2024

Closes #70

Proposed Changes

Rename FlightSQL constant to SQL.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (f0bf1b6) to head (5fe866c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files          12       12           
  Lines         994      994           
=======================================
  Hits          826      826           
  Misses        138      138           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review March 27, 2024 10:57
@jstirnaman
Copy link
Contributor

Thanks!

@bednar bednar force-pushed the rename_flight_sql_constant branch from 39a7c6b to 5fe866c Compare April 12, 2024 12:42
@bednar bednar merged commit 567467e into main Apr 12, 2024
11 checks passed
@bednar bednar deleted the rename_flight_sql_constant branch April 12, 2024 12:48
@bednar bednar added this to the 0.7.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryType constant should be SQL instead of FlightSQL
3 participants