feat: type-safe conversion for line-protocol Addfield #43 #42

arukiidou · 2023-09-25T23:00:03Z

Closes Type-safe conversion for line-protocol Addfield #43
- back to draft. in favor of feat: add structured query #45.

Proposed Changes

Add line-protocol compliant wrapper
Add generic type constraints
- line-protocol type
  - Float
  - Integer
  - Uinteger
  - String
  - Bool
- native go <> line-protocol shortcut
- time.Time conversion
- time.Duration - using fmt.Stringer

func (m *Point) AddFieldFromValue(k string, v lineprotocol.Value) *Point {}
func NewValueFromInt[I Integer](v I) lineprotocol.Value {}

Usage

func example() {
	p := NewPoint("measurement", map[string]string{}, map[string]interface{}{"measurement": "air"}, time.Now())
        // unsupported type.
	p.AddFieldFromValue("✅ Compile error.", cmplx.Inf())
        // supported type.
	p.AddFieldFromValue("✅ This is safe.", NewValueFromInt(255))
}

Checklist

bednar · 2023-09-26T08:41:29Z

@arukiidou, thank you for using our client and for your PR. We're excited to review it once it's ready.

arukiidou · 2023-10-02T08:10:35Z

ready for review. 👍
rebased behind of v0.3.0

arukiidou · 2023-10-02T09:05:27Z

fixed,sorry🙏

bednar · 2023-10-03T08:48:09Z

influxdb3/value.go

+	float64 | int64 | uint64 | string | []byte | bool
+}
+
+// [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.


Add Float as a prefix to docs:

Suggested change

// [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.

// Float [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.

bednar · 2023-10-03T08:48:38Z

influxdb3/value.go

+	~float32 | ~float64
+}
+
+// [Integer] is signed 64-bit integers.


Add Integer as a prefix to docs:

Suggested change

// [Integer] is signed 64-bit integers.

// Integer [Integer] is signed 64-bit integers.

bednar · 2023-10-03T08:49:26Z

influxdb3/value.go

+	~int | ~int8 | ~int16 | ~int32 | ~int64
+}
+
+// [UInteger] is unsigned 64-bit integers.


Add UInteger as a prefix to docs:

Suggested change

// [UInteger] is unsigned 64-bit integers.

// UInteger [UInteger] is unsigned 64-bit integers.

bednar · 2023-10-03T08:49:49Z

influxdb3/value.go

+	~uint | ~uint8 | ~uint16 | ~uint32 | ~uint64
+}
+
+// [String] is plain text string. Length limit 64KB.


Add String as a prefix to docs:

Suggested change

// [String] is plain text string. Length limit 64KB.

// String [String] is plain text string. Length limit 64KB.

bednar · 2023-10-03T08:50:22Z

influxdb3/value.go

+	~string | ~[]byte
+}
+
+// [Boolean] is true or false values.


Add Boolean as a prefix to docs:

Suggested change

// [Boolean] is true or false values.

// Boolean [Boolean] is true or false values.

bednar · 2023-10-03T09:14:51Z

I have a question regarding the use of lineprotocol.Value. Is its usage necessary? What do you think about adding something like AddStringField(k string, v string) to Point?

func (m *Point) AddStringField(k string, v string) *Point {
	m.AddField(k, v)
	return m
}

arukiidou · 2023-10-04T12:11:05Z

I have a question regarding the use of lineprotocol.Value. Is its usage necessary? What do you think about adding something like AddStringField(k string, v string) to Point?
func (m *Point) AddStringField(k string, v string) *Point {
	m.AddField(k, v)
	return m
}

Oh, I prefer AddStringField better.

bednar · 2023-10-06T08:59:10Z

We aim to synchronize the API across our v3 clients — js, go, java, and c#. We've already updated the API in both the c# and js clients. For more information, see:

JS Client PR #89
JS Client PR #89 File Diff
C# Client PR #52
C# Client PR #52 File Diff

bednar · 2023-10-18T11:44:31Z

@arukiidou thanks again for your PR. Can you please align your code with upcoming changes for structured query - #45?

arukiidou · 2023-10-18T12:48:10Z

@arukiidou thanks again for your PR. Can you please align your code with upcoming changes for structured query - #45?

Yes, I will do so. It may take some time.

Signed-off-by: junya koyama <[email protected]>

arukiidou · 2023-10-29T13:49:19Z

@bednar

After a little consideration, I seem to be mostly satisfied with feat: add structured query #45. I don't see anything to add, thanks!

arukiidou mentioned this pull request Sep 26, 2023

Type-safe conversion for line-protocol Addfield #43

Closed

arukiidou force-pushed the feature/add-guardrail branch 3 times, most recently from 10fcc48 to 377043a Compare October 1, 2023 14:48

arukiidou marked this pull request as ready for review October 1, 2023 14:49

arukiidou changed the title ~~[Draft] Support Type Guard~~ feat: type-safe conversion for line-protocol Addfield #43 Oct 1, 2023

bednar requested changes Oct 3, 2023

View reviewed changes

arukiidou mentioned this pull request Oct 4, 2023

Simple Addvalue types #44

Closed

arukiidou force-pushed the feature/add-guardrail branch 2 times, most recently from 5f4b40c to d741d07 Compare October 18, 2023 10:25

arukiidou requested a review from bednar October 18, 2023 10:27

arukiidou marked this pull request as draft October 18, 2023 10:28

arukiidou added 6 commits October 26, 2023 23:28

feat: type-safe conversion for line-protocol

e8baddf

Signed-off-by: junya koyama <[email protected]>

feat: add unit test

f851192

Signed-off-by: junya koyama <[email protected]>

feat: add examples, fix doc comments.

85f69f1

Signed-off-by: junya koyama <[email protected]>

fix: doc comment fixed in value.go

7b253af

fix: fixed comment suggestion

29e2d5d

Signed-off-by: junya koyama <[email protected]>

feat: add CHANGELOG.md

5ffea2d

Signed-off-by: junya koyama <[email protected]>

arukiidou force-pushed the feature/add-guardrail branch from f67bb6f to 5ffea2d Compare October 26, 2023 14:30

arukiidou closed this Oct 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: type-safe conversion for line-protocol Addfield #43 #42

feat: type-safe conversion for line-protocol Addfield #43 #42

arukiidou commented Sep 25, 2023 •

edited

Loading

bednar commented Sep 26, 2023

arukiidou commented Oct 2, 2023

arukiidou commented Oct 2, 2023

bednar Oct 3, 2023

arukiidou Oct 18, 2023

bednar Oct 3, 2023

arukiidou Oct 18, 2023

bednar Oct 3, 2023

arukiidou Oct 18, 2023

bednar Oct 3, 2023

arukiidou Oct 18, 2023

bednar Oct 3, 2023

arukiidou Oct 18, 2023

bednar commented Oct 3, 2023

arukiidou commented Oct 4, 2023 •

edited

Loading

bednar commented Oct 6, 2023

bednar commented Oct 18, 2023

arukiidou commented Oct 18, 2023

arukiidou commented Oct 29, 2023

	// [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.
	// Float [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.

	// [Integer] is signed 64-bit integers.
	// Integer [Integer] is signed 64-bit integers.

	// [UInteger] is unsigned 64-bit integers.
	// UInteger [UInteger] is unsigned 64-bit integers.

	// [String] is plain text string. Length limit 64KB.
	// String [String] is plain text string. Length limit 64KB.

	// [Boolean] is true or false values.
	// Boolean [Boolean] is true or false values.

feat: type-safe conversion for line-protocol Addfield #43 #42

feat: type-safe conversion for line-protocol Addfield #43 #42

Conversation

arukiidou commented Sep 25, 2023 • edited Loading

Proposed Changes

Usage

Checklist

bednar commented Sep 26, 2023

arukiidou commented Oct 2, 2023

arukiidou commented Oct 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bednar commented Oct 3, 2023

arukiidou commented Oct 4, 2023 • edited Loading

bednar commented Oct 6, 2023

bednar commented Oct 18, 2023

arukiidou commented Oct 18, 2023

arukiidou commented Oct 29, 2023

arukiidou commented Sep 25, 2023 •

edited

Loading

arukiidou commented Oct 4, 2023 •

edited

Loading