-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React native #49
Draft
KhanIAtlas
wants to merge
39
commits into
master
Choose a base branch
from
react-native
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
React native #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add React.Native support using https://github.com/remobile/react-native-cordova Idea is to keep this in different branch from master Cordova branch, but merging changes should be relatively easy/conflict free. Basicly setup for existing project should be as easy as adding react-native-indooratlas dep to package.json (pointing to react-native branch in github repo) and to iOS/Android build files. ``` "react-native-indooratlas": "git+https://github.com/indooratlas/cordova-plugin.git#react-native", ``` then run `yarn install`. iOS: add pod deps to Podfile ``` pod 'RCTCordova', :path => '../node_modules/@remobile/react-native-cordova/ios' pod 'RCTIndoorAtlas', :path => '../node_modules/react-native-indooratlas/src/ios' ``` and run `pod install`. Android: add projects to settings.gradle: ``` include ':react-native-cordova' project(':react-native-cordova').projectDir = file('../node_modules/@remobile/react-native-cordova/android') include ':react-native-indooratlas' project(':react-native-indooratlas').projectDir = file('../node_modules/react-native-indooratlas/src/android') ``` add react-native-indooratlas dep to app/build.gradle: ``` implementation project(':react-native-indooratlas') ``` Probably should marked as "alpha" or "experimental" or something.
* Update to SDK 3.4.7 * Update README
In the react-native branch the leading { of the package.json file is missing.
Update IndoorAtlas SDKs to 3.5.5
Update IndoorAtlas SDKs to 3.6.3
Update IndoorAtlas SDKs to 3.6.4
Update IndoorAtlas SDKs to 3.6.7/3.6.8
Update IndoorAtlas SDKs to 3.6.9
NOTE! To enable the callbacks, please contact IndoorAtlas support.
…acks React Native radio scan callbacks
Containing fix for numbers being truncated.
no longer needed with IA fork of react-native-cordova
Update IndoorAtlas SDKs to 3.6.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.