feat: add support to new crossprofiles #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDorado
requested changes
Oct 24, 2024
server/auth/devhub/aplication.go
Outdated
| servicesAndRoles := &RolesAndServices{} | ||
| apiDevhub := fmt.Sprintf("%s/api/identity/%s", apiUrl, userToIdentify) | ||
| func GetServicesAndGroup(devhubclient *Client, apiUrl, apiEndpoint, apiPassword, userToIdentify string, writeGroups []string) (*GroupAndServices, error) { | ||
| var result map[string]interface{} |
There was a problem hiding this comment.
IMO, it is better to pass a struct because the response is typed, then we do not have to cast and check if it is a string or not in GetRolesAndServices.
I have not tested it, but getting the OpenAPI specification and using https://github.com/OpenAPITools/openapi-generator will create a good structure.
DanielDorado
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/inditex/iac-sentijobs/issues/130