[DOP-2325][DEV-12391][DEV-12396][DOP-2328] EKS cluster module update, IAM module introduction #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltellesfl
previously approved these changes
Nov 19, 2024
* Update sqs_sns module version and add variables * Rollback removed outputs * Add default value for sqs_sns variables
ltellesfl
changed the title
This reverts commit 6fdd1ec.
…rgo application file" This reverts commit dbaf44d.
…on (#365) * Enable self_heal and add ServerSideApply=true to deploy-ipa application * Enable self_heal and add ServerSideApply=true to azure deploy-ipa application * Match what actually gets applied to avoid terraform overwrites * Match what ends up in the final argo application --------- Co-authored-by: Andrey Chmykh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node group role and s3 replication role handled by the new IAM module.
Found that the s3 module in tf_cod doesn't allow us to specify variables in a way to enable cross region replication. This also turned out to be a good thing since the policy before this change had a / permission.
Need an additional ticket to allow enabling cross region replication
Also, sns/sqs module did have a policy, but it was never applied anywhere.