Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-11445] implement submission filter parity #141

Merged
merged 7 commits into from
Mar 7, 2024
Merged

[DEV-11445] implement submission filter parity #141

merged 7 commits into from
Mar 7, 2024

Conversation

nateshim-indico
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Total Coverage: 15.85%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
IndicoV2
   IndicoClient.cs100%71.43%86.96%30, 79, 80
   IndicoClientExtensions.cs100%92.31%92.31%85
IndicoV2.Abstractions/CommonModels/Pagination
   HasCursor.cs100%0%0%11, 9
   PageInfo.cs100%0%0%13, 17, 21, 25
IndicoV2.Abstractions/CommonModels/Predictions
   Prediction.cs100%0%0%12, 15, 18, 21, 9
IndicoV2.Abstractions/Converters
   CastingConverter.cs0%0%0%12, 14, 18, 18, 18, 20, 9
IndicoV2.Abstractions/DataSets/Models
   DataSet.cs100%0%0%5, 6
   DataSetFull.cs100%0%0%10, 11, 12, 7, 8, 9
IndicoV2.Abstractions/Extensions/SubmissionResult/Exceptions
   WrongSubmissionStatusException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Jobs/Exceptions
   JobNotSuccessfulException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Models/Models
   Model.cs100%0%0%5, 6, 7
   ModelGroup.cs100%0%0%5, 6, 7, 8
   ModelGroupBase.cs100%0%0%5
   PredictionJobResult.cs100%0%0%15, 17, 19, 21, 24
IndicoV2.Abstractions/Ocr/Models
   ExtractionJobResult.cs100%0%0%10
IndicoV2.Abstractions/Storage/Models
   FileMetadata.cs100%0%0%11, 14, 17, 8
IndicoV2.Abstractions/Submissions/Models
   AndFilter.cs100%0%0%10
   SubmissionFilter.cs100%0%0%40, 41
   FilterConverter.cs0%0%0%17, 17, 17, 19, 19, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 42, 42, 42, 44, 45, 46, 47, 50, 50, 50, 52, 53, 54, 55, 57
   OrFilter.cs100%0%0%10
   Submission.cs100%0%0%39, 41, 43, 45, 47, 49, 51, 53, 55, 57
   Submission.cs100%0%0%101, 103, 108, 113, 115, 120, 125, 130, 132, 137, 139, 141, 143, 145, 147, 149, 78, 83, 88, 93, 95, 97, 99
   Submission.cs100%0%0%11, 13, 15, 17, 19, 21, 9
   SubmissionFilter.cs100%0%0%46, 47, 48, 49, 50, 51, 52, 53, 54
   Submission.cs100%0%0%26, 28, 30, 32, 34
   Submission.cs100%0%0%62, 64, 66, 68, 70
   SubmissionFilter.cs100%0%0%33, 34, 35
   Submission.cs0%0%0%155, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 183, 183, 184, 184, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 226, 226, 226, 226, 226, 226, 226, 226, 226, 226, 229, 231, 233, 235, 237, 239, 241
IndicoV2.Abstractions/Workflows/Models
   Workflow.cs100%0%0%10, 11, 12
IndicoV2/DataSets
   DataSetClient.cs0%11.11%11.76%26, 27, 27, 27, 27, 27, 28, 29, 33, 34, 34, 34, 34, 34, 35, 36, 41, 42, 43, 45, 46, 50, 53, 56, 58, 59, 60, 61, 62, 64, 64, 64, 65, 66, 67, 68, 69, 70, 71, 72
IndicoV2/Exception
   FileUploadException.cs100%0%0%10, 11, 12, 15
   GraphQLException.cs0%0%0%11, 13, 15, 17, 21, 25, 26, 27, 28, 28, 28, 30, 32
IndicoV2/Extensions/DataSets
   DataSetAwaiter.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders
   JobResultBuilder.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission
   UrlJobResult.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission/Exceptions
   InvalidJobSubmissionResult.cs100%50%50%9
   InvalidUrlException.cs100%50%50%9
IndicoV2/Extensions/Jobs
   JobAwaiter.cs100%75%93.33%31
IndicoV2/Extensions/SubmissionResult
   SubmissionResultAwaiter.cs100%100%100%
IndicoV2/Extensions/Workflows
   WorkflowAwaiter.cs0%50%25%17, 17, 17, 19, 21
IndicoV2/GraphQLRequest
   GraphQLRequestClient.cs0%0%0%17, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 32, 32, 32, 34, 36, 37, 38, 39, 40, 42, 43, 43, 43, 45, 48, 48, 48, 49, 50
IndicoV2/Jobs
   JobsClient.cs0%25%20%25, 26, 27, 31, 33, 34, 38, 39, 40, 40, 40, 42, 43, 45, 46, 47, 49, 50
IndicoV2/Models
   ModelsClient.cs0%14.29%13.79%28, 29, 30, 36, 37, 38, 43, 44, 45, 49, 50, 51, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 54, 55, 56, 57, 58, 60, 61, 62, 63, 64, 65, 66
IndicoV2/Ocr
   OcrClient.cs0%20%11.43%28, 29, 30, 31, 36, 37, 38, 38, 38, 40, 41, 42, 43, 44, 45, 47, 48, 49, 50, 51, 53, 55, 56, 57, 58, 60, 62, 63, 65, 69, 70, 72, 74
IndicoV2/Reviews
   ReviewsClient.cs100%33.33%66.67%22, 25
IndicoV2/Storage
   Blob.cs100%0%0%15, 17, 23, 31, 32, 41, 42, 51, 52
   FileParameter.cs100%0%0%10, 7, 8, 9
   MultipartFormUpload.cs0%0%0%16, 18, 22, 22, 22, 23, 24, 25, 26, 27, 28, 29, 33, 34, 35, 36, 37, 39, 39, 39, 42, 42, 42, 44, 47, 49, 50, 51, 52, 53, 55, 56, 57, 60, 61, 64, 65, 66, 67, 70, 71, 72, 73, 74
   RetrieveBlob.cs0%0%0%19, 21, 23, 24, 24, 24, 25, 32, 42, 43, 44, 45, 46, 50, 51, 51, 51, 53, 57, 59, 67, 68, 69, 69, 69, 71, 75, 77, 85, 86, 87
   StorageClient.cs0%11.11%13.33%100, 103, 105, 106, 107, 108, 110, 111, 112, 115, 116, 119, 120, 121, 122, 125, 126, 127, 129, 130, 29, 35, 36, 38, 39, 43, 45, 46, 50, 51, 53, 58, 59, 61, 67, 72, 73, 75, 77, 79, 80, 81, 82, 83, 85, 89, 90, 91, 92, 93, 95, 95, 95, 98, 98, 98
   UploadFile.cs0%0%0%14, 21, 22, 25, 29, 29, 29, 31, 32, 33, 35, 35, 35, 37, 40, 40, 40, 42, 46, 49, 57, 59, 59, 59, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 73, 74, 75, 76, 77, 80, 82, 82, 82, 84, 85, 85, 85, 87, 88, 90, 94, 95
   UploadStream.cs0%0%0%18, 20, 28, 30, 30, 30, 32, 33, 34, 35, 36, 37, 38, 39, 40, 43, 44, 45, 46, 47, 49, 49, 49, 51, 52, 52, 52, 54, 55, 56, 60, 61
IndicoV2/Submissions
   SubmissionsClient.cs0%8.33%5%101, 101, 101, 103, 104, 105, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 123, 124, 124, 124, 126, 128, 128, 128, 128, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 144, 148, 149, 150, 150, 150, 150, 150, 151, 153, 28, 29, 30, 31, 32, 33, 34, 34, 34, 36, 37, 38, 39, 40, 41, 43, 44, 45, 46, 47, 49, 51, 51, 51, 52, 56, 57, 57, 57, 58, 64, 68, 73, 74, 74, 74, 76, 76, 76, 78, 79, 83, 87, 88, 94, 95, 96
IndicoV2/Workflows
   WorkflowsClient.cs100%14.29%20%23, 24, 25, 29, 30, 31, 35, 36, 37, 40, 43, 45, 46, 47, 48, 49

@goatrocks
Copy link
Contributor

Looks good so far, definitely want some thorough unit tests for the different filter permutations/possibilities for casts between enums

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Total Coverage: 15.91%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
IndicoV2
   IndicoClient.cs100%71.43%86.96%30, 79, 80
   IndicoClientExtensions.cs100%92.31%92.31%85
IndicoV2.Abstractions/CommonModels/Pagination
   HasCursor.cs100%0%0%11, 9
   PageInfo.cs100%0%0%13, 17, 21, 25
IndicoV2.Abstractions/CommonModels/Predictions
   Prediction.cs100%0%0%12, 15, 18, 21, 9
IndicoV2.Abstractions/Converters
   CastingConverter.cs0%0%0%12, 14, 18, 18, 18, 20, 9
IndicoV2.Abstractions/DataSets/Models
   DataSet.cs100%0%0%5, 6
   DataSetFull.cs100%0%0%10, 11, 12, 7, 8, 9
IndicoV2.Abstractions/Extensions/SubmissionResult/Exceptions
   WrongSubmissionStatusException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Jobs/Exceptions
   JobNotSuccessfulException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Models/Models
   Model.cs100%0%0%5, 6, 7
   ModelGroup.cs100%0%0%5, 6, 7, 8
   ModelGroupBase.cs100%0%0%5
   PredictionJobResult.cs100%0%0%15, 17, 19, 21, 24
IndicoV2.Abstractions/Ocr/Models
   ExtractionJobResult.cs100%0%0%10
IndicoV2.Abstractions/Storage/Models
   FileMetadata.cs100%0%0%11, 14, 17, 8
IndicoV2.Abstractions/Submissions/Models
   AndFilter.cs100%0%0%10
   SubmissionFilter.cs100%0%0%21, 22
   FilterConverter.cs0%0%0%17, 17, 17, 19, 19, 19, 19, 19, 19, 19, 19, 19, 19, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 45, 45, 45, 47, 48, 49, 50, 53, 53, 53, 55, 56, 57, 58, 60
   OrFilter.cs100%0%0%10
   Submission.cs100%0%0%104, 109, 114, 119, 78, 83, 88, 93, 99
   Submission.cs100%0%0%156, 161, 166, 171, 176, 181, 186, 191, 196, 201, 206, 211, 216, 221, 226, 231, 236, 241, 246, 251, 256
   Submission.cs100%0%0%12, 17, 22, 27, 32, 37, 42
   SubmissionFilter.cs100%0%0%27, 28, 30, 32, 34, 36, 38, 40, 42
   Submission.cs100%0%0%50, 55, 60, 65, 70
   Submission.cs100%0%0%128, 133, 138, 143, 148
   SubmissionFilter.cs100%0%0%14, 15, 16
   Submission.cs0%0%0%262, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 290, 290, 291, 291, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 329, 329, 329, 329, 329, 329, 329, 329, 329, 329, 332, 334, 336, 338, 340, 342, 344
IndicoV2.Abstractions/Workflows/Models
   Workflow.cs100%0%0%10, 11, 12
IndicoV2/DataSets
   DataSetClient.cs0%11.11%11.76%26, 27, 27, 27, 27, 27, 28, 29, 33, 34, 34, 34, 34, 34, 35, 36, 41, 42, 43, 45, 46, 50, 53, 56, 58, 59, 60, 61, 62, 64, 64, 64, 65, 66, 67, 68, 69, 70, 71, 72
IndicoV2/Exception
   FileUploadException.cs100%0%0%10, 11, 12, 15
   GraphQLException.cs0%0%0%11, 13, 15, 17, 21, 25, 26, 27, 28, 28, 28, 30, 32
IndicoV2/Extensions/DataSets
   DataSetAwaiter.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders
   JobResultBuilder.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission
   UrlJobResult.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission/Exceptions
   InvalidJobSubmissionResult.cs100%50%50%9
   InvalidUrlException.cs100%50%50%9
IndicoV2/Extensions/Jobs
   JobAwaiter.cs100%75%93.33%31
IndicoV2/Extensions/SubmissionResult
   SubmissionResultAwaiter.cs100%100%100%
IndicoV2/Extensions/Workflows
   WorkflowAwaiter.cs0%50%25%17, 17, 17, 19, 21
IndicoV2/GraphQLRequest
   GraphQLRequestClient.cs0%0%0%17, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 32, 32, 32, 34, 36, 37, 38, 39, 40, 42, 43, 43, 43, 45, 48, 48, 48, 49, 50
IndicoV2/Jobs
   JobsClient.cs0%25%20%25, 26, 27, 31, 33, 34, 38, 39, 40, 40, 40, 42, 43, 45, 46, 47, 49, 50
IndicoV2/Models
   ModelsClient.cs0%14.29%13.79%28, 29, 30, 36, 37, 38, 43, 44, 45, 49, 50, 51, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 54, 55, 56, 57, 58, 60, 61, 62, 63, 64, 65, 66
IndicoV2/Ocr
   OcrClient.cs0%20%11.43%28, 29, 30, 31, 36, 37, 38, 38, 38, 40, 41, 42, 43, 44, 45, 47, 48, 49, 50, 51, 53, 55, 56, 57, 58, 60, 62, 63, 65, 69, 70, 72, 74
IndicoV2/Reviews
   ReviewsClient.cs100%33.33%66.67%22, 25
IndicoV2/Storage
   Blob.cs100%0%0%15, 17, 23, 31, 32, 41, 42, 51, 52
   FileParameter.cs100%0%0%10, 7, 8, 9
   MultipartFormUpload.cs0%0%0%16, 18, 22, 22, 22, 23, 24, 25, 26, 27, 28, 29, 33, 34, 35, 36, 37, 39, 39, 39, 42, 42, 42, 44, 47, 49, 50, 51, 52, 53, 55, 56, 57, 60, 61, 64, 65, 66, 67, 70, 71, 72, 73, 74
   RetrieveBlob.cs0%0%0%19, 21, 23, 24, 24, 24, 25, 32, 42, 43, 44, 45, 46, 50, 51, 51, 51, 53, 57, 59, 67, 68, 69, 69, 69, 71, 75, 77, 85, 86, 87
   StorageClient.cs0%11.11%13.33%100, 103, 105, 106, 107, 108, 110, 111, 112, 115, 116, 119, 120, 121, 122, 125, 126, 127, 129, 130, 29, 35, 36, 38, 39, 43, 45, 46, 50, 51, 53, 58, 59, 61, 67, 72, 73, 75, 77, 79, 80, 81, 82, 83, 85, 89, 90, 91, 92, 93, 95, 95, 95, 98, 98, 98
   UploadFile.cs0%0%0%14, 21, 22, 25, 29, 29, 29, 31, 32, 33, 35, 35, 35, 37, 40, 40, 40, 42, 46, 49, 57, 59, 59, 59, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 73, 74, 75, 76, 77, 80, 82, 82, 82, 84, 85, 85, 85, 87, 88, 90, 94, 95
   UploadStream.cs0%0%0%18, 20, 28, 30, 30, 30, 32, 33, 34, 35, 36, 37, 38, 39, 40, 43, 44, 45, 46, 47, 49, 49, 49, 51, 52, 52, 52, 54, 55, 56, 60, 61
IndicoV2/Submissions
   SubmissionsClient.cs0%8.33%4.94%101, 101, 101, 103, 104, 105, 106, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 124, 125, 125, 125, 127, 129, 129, 129, 129, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 145, 149, 150, 151, 151, 151, 151, 151, 152, 154, 28, 29, 30, 31, 32, 33, 34, 34, 34, 36, 37, 38, 39, 40, 41, 43, 44, 45, 46, 47, 49, 51, 51, 51, 52, 56, 57, 57, 57, 58, 64, 68, 73, 74, 74, 74, 76, 76, 76, 78, 79, 83, 87, 88, 94, 95, 96
IndicoV2/Workflows
   WorkflowsClient.cs100%14.29%20%23, 24, 25, 29, 30, 31, 35, 36, 37, 40, 43, 45, 46, 47, 48, 49

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Total Coverage: 15.75%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
IndicoV2
   IndicoClient.cs100%71.43%86.96%30, 79, 80
   IndicoClientExtensions.cs100%92.31%92.31%85
IndicoV2.Abstractions/CommonModels/Pagination
   HasCursor.cs100%0%0%11, 9
   PageInfo.cs100%0%0%13, 17, 21, 25
IndicoV2.Abstractions/CommonModels/Predictions
   Prediction.cs100%0%0%12, 15, 18, 21, 9
IndicoV2.Abstractions/Converters
   CastingConverter.cs0%0%0%12, 14, 18, 18, 18, 20, 9
IndicoV2.Abstractions/DataSets/Models
   DataSet.cs100%0%0%5, 6
   DataSetFull.cs100%0%0%10, 11, 12, 7, 8, 9
IndicoV2.Abstractions/Extensions/SubmissionResult/Exceptions
   WrongSubmissionStatusException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Jobs/Exceptions
   JobNotSuccessfulException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Models/Models
   Model.cs100%0%0%5, 6, 7
   ModelGroup.cs100%0%0%5, 6, 7, 8
   ModelGroupBase.cs100%0%0%5
   PredictionJobResult.cs100%0%0%15, 17, 19, 21, 24
IndicoV2.Abstractions/Ocr/Models
   ExtractionJobResult.cs100%0%0%10
IndicoV2.Abstractions/Storage/Models
   FileMetadata.cs100%0%0%11, 14, 17, 8
IndicoV2.Abstractions/Submissions/Models
   AndFilter.cs100%0%0%10
   SubmissionFilter.cs100%0%0%21, 22
   FilterConverter.cs0%0%0%17, 17, 17, 19, 20, 20, 20, 22, 24, 24, 24, 26, 28, 28, 28, 30, 32, 32, 32, 34, 34, 34, 36, 36, 36, 38, 39, 40, 41, 42, 43, 45, 45, 45, 47, 49, 49, 49, 51, 53, 53, 53, 55, 56, 57, 58, 59, 61, 61, 61, 63, 64, 65, 66, 67, 69, 71, 71, 71, 73, 74, 75, 76, 79, 79, 79, 81, 82, 83, 84, 86
   OrFilter.cs100%0%0%10
   Submission.cs100%0%0%104, 109, 114, 119, 78, 83, 88, 93, 99
   Submission.cs100%0%0%156, 161, 166, 171, 176, 181, 186, 191, 196, 201, 206, 211, 216, 221, 226, 231, 236, 241, 246, 251, 256
   Submission.cs100%0%0%12, 17, 22, 27, 32, 37, 42
   SubmissionFilter.cs100%0%0%27, 28, 30, 32, 34, 36, 38, 40, 42
   Submission.cs100%0%0%50, 55, 60, 65, 70
   Submission.cs100%0%0%128, 133, 138, 143, 148
   SubmissionFilter.cs100%0%0%14, 15, 16
   Submission.cs0%0%0%262, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 290, 290, 291, 291, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 329, 329, 329, 329, 329, 329, 329, 329, 329, 329, 332, 334, 336, 338, 340, 342, 344
IndicoV2.Abstractions/Workflows/Models
   Workflow.cs100%0%0%10, 11, 12
IndicoV2/DataSets
   DataSetClient.cs0%11.11%11.76%26, 27, 27, 27, 27, 27, 28, 29, 33, 34, 34, 34, 34, 34, 35, 36, 41, 42, 43, 45, 46, 50, 53, 56, 58, 59, 60, 61, 62, 64, 64, 64, 65, 66, 67, 68, 69, 70, 71, 72
IndicoV2/Exception
   FileUploadException.cs100%0%0%10, 11, 12, 15
   GraphQLException.cs0%0%0%11, 13, 15, 17, 21, 25, 26, 27, 28, 28, 28, 30, 32
IndicoV2/Extensions/DataSets
   DataSetAwaiter.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders
   JobResultBuilder.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission
   UrlJobResult.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission/Exceptions
   InvalidJobSubmissionResult.cs100%50%50%9
   InvalidUrlException.cs100%50%50%9
IndicoV2/Extensions/Jobs
   JobAwaiter.cs100%75%93.33%31
IndicoV2/Extensions/SubmissionResult
   SubmissionResultAwaiter.cs100%100%100%
IndicoV2/Extensions/Workflows
   WorkflowAwaiter.cs0%50%25%17, 17, 17, 19, 21
IndicoV2/GraphQLRequest
   GraphQLRequestClient.cs0%0%0%17, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 32, 32, 32, 34, 36, 37, 38, 39, 40, 42, 43, 43, 43, 45, 48, 48, 48, 49, 50
IndicoV2/Jobs
   JobsClient.cs0%25%20%25, 26, 27, 31, 33, 34, 38, 39, 40, 40, 40, 42, 43, 45, 46, 47, 49, 50
IndicoV2/Models
   ModelsClient.cs0%14.29%13.79%28, 29, 30, 36, 37, 38, 43, 44, 45, 49, 50, 51, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 54, 55, 56, 57, 58, 60, 61, 62, 63, 64, 65, 66
IndicoV2/Ocr
   OcrClient.cs0%20%11.43%28, 29, 30, 31, 36, 37, 38, 38, 38, 40, 41, 42, 43, 44, 45, 47, 48, 49, 50, 51, 53, 55, 56, 57, 58, 60, 62, 63, 65, 69, 70, 72, 74
IndicoV2/Reviews
   ReviewsClient.cs100%33.33%66.67%22, 25
IndicoV2/Storage
   Blob.cs100%0%0%15, 17, 23, 31, 32, 41, 42, 51, 52
   FileParameter.cs100%0%0%10, 7, 8, 9
   MultipartFormUpload.cs0%0%0%16, 18, 22, 22, 22, 23, 24, 25, 26, 27, 28, 29, 33, 34, 35, 36, 37, 39, 39, 39, 42, 42, 42, 44, 47, 49, 50, 51, 52, 53, 55, 56, 57, 60, 61, 64, 65, 66, 67, 70, 71, 72, 73, 74
   RetrieveBlob.cs0%0%0%19, 21, 23, 24, 24, 24, 25, 32, 42, 43, 44, 45, 46, 50, 51, 51, 51, 53, 57, 59, 67, 68, 69, 69, 69, 71, 75, 77, 85, 86, 87
   StorageClient.cs0%11.11%13.33%100, 103, 105, 106, 107, 108, 110, 111, 112, 115, 116, 119, 120, 121, 122, 125, 126, 127, 129, 130, 29, 35, 36, 38, 39, 43, 45, 46, 50, 51, 53, 58, 59, 61, 67, 72, 73, 75, 77, 79, 80, 81, 82, 83, 85, 89, 90, 91, 92, 93, 95, 95, 95, 98, 98, 98
   UploadFile.cs0%0%0%14, 21, 22, 25, 29, 29, 29, 31, 32, 33, 35, 35, 35, 37, 40, 40, 40, 42, 46, 49, 57, 59, 59, 59, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 73, 74, 75, 76, 77, 80, 82, 82, 82, 84, 85, 85, 85, 87, 88, 90, 94, 95
   UploadStream.cs0%0%0%18, 20, 28, 30, 30, 30, 32, 33, 34, 35, 36, 37, 38, 39, 40, 43, 44, 45, 46, 47, 49, 49, 49, 51, 52, 52, 52, 54, 55, 56, 60, 61
IndicoV2/Submissions
   SubmissionsClient.cs0%8.33%4.94%101, 101, 101, 103, 104, 105, 106, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 124, 125, 125, 125, 127, 129, 129, 129, 129, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 145, 149, 150, 151, 151, 151, 151, 151, 152, 154, 28, 29, 30, 31, 32, 33, 34, 34, 34, 36, 37, 38, 39, 40, 41, 43, 44, 45, 46, 47, 49, 51, 51, 51, 52, 56, 57, 57, 57, 58, 64, 68, 73, 74, 74, 74, 76, 76, 76, 78, 79, 83, 87, 88, 94, 95, 96
IndicoV2/Workflows
   WorkflowsClient.cs100%14.29%20%23, 24, 25, 29, 30, 31, 35, 36, 37, 40, 43, 45, 46, 47, 48, 49

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Total Coverage: 15.77%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
IndicoV2
   IndicoClient.cs100%71.43%86.96%30, 79, 80
   IndicoClientExtensions.cs100%92.31%92.31%85
IndicoV2.Abstractions/CommonModels/Pagination
   HasCursor.cs100%0%0%11, 9
   PageInfo.cs100%0%0%13, 17, 21, 25
IndicoV2.Abstractions/CommonModels/Predictions
   Prediction.cs100%0%0%12, 15, 18, 21, 9
IndicoV2.Abstractions/Converters
   CastingConverter.cs0%0%0%12, 14, 18, 18, 18, 20, 9
IndicoV2.Abstractions/DataSets/Models
   DataSet.cs100%0%0%5, 6
   DataSetFull.cs100%0%0%10, 11, 12, 7, 8, 9
IndicoV2.Abstractions/Extensions/SubmissionResult/Exceptions
   WrongSubmissionStatusException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Jobs/Exceptions
   JobNotSuccessfulException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Models/Models
   Model.cs100%0%0%5, 6, 7
   ModelGroup.cs100%0%0%5, 6, 7, 8
   ModelGroupBase.cs100%0%0%5
   PredictionJobResult.cs100%0%0%15, 17, 19, 21, 24
IndicoV2.Abstractions/Ocr/Models
   ExtractionJobResult.cs100%0%0%10
IndicoV2.Abstractions/Storage/Models
   FileMetadata.cs100%0%0%11, 14, 17, 8
IndicoV2.Abstractions/Submissions/Models
   AndFilter.cs100%0%0%10
   SubmissionFilter.cs100%0%0%21, 22
   FilterConverter.cs0%0%0%17, 17, 17, 19, 20, 20, 20, 22, 24, 24, 24, 26, 28, 28, 28, 30, 32, 32, 32, 34, 34, 34, 36, 36, 36, 38, 39, 40, 41, 42, 43, 45, 45, 45, 47, 49, 49, 49, 51, 53, 53, 53, 55, 56, 57, 58, 59, 61, 61, 61, 63, 64, 65, 66, 67, 69, 71, 71, 71, 73, 74, 75, 76, 79, 79, 79, 81, 82, 83, 84, 86
   OrFilter.cs100%0%0%10
   Submission.cs100%0%0%104, 109, 114, 119, 78, 83, 88, 93, 99
   Submission.cs100%0%0%156, 161, 166, 171, 176, 181, 186, 191, 196, 201, 206, 211, 216, 221, 226, 231, 236, 241, 246, 251, 256
   Submission.cs100%0%0%12, 17, 22, 27, 32, 37, 42
   SubmissionFilter.cs100%0%0%27, 28, 30, 32, 34, 36, 38, 40, 42
   Submission.cs100%0%0%50, 55, 60, 65, 70
   Submission.cs100%0%0%128, 133, 138, 143, 148
   SubmissionFilter.cs100%0%0%14, 15, 16
   Submission.cs0%0%0%262, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 290, 290, 291, 291, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 329, 329, 329, 329, 329, 329, 329, 329, 329, 329, 332, 334, 336, 338, 340, 342, 344
IndicoV2.Abstractions/Workflows/Models
   Workflow.cs100%0%0%10, 11, 12
IndicoV2/DataSets
   DataSetClient.cs0%11.11%11.76%26, 27, 27, 27, 27, 27, 28, 29, 33, 34, 34, 34, 34, 34, 35, 36, 41, 42, 43, 45, 46, 50, 53, 56, 58, 59, 60, 61, 62, 64, 64, 64, 65, 66, 67, 68, 69, 70, 71, 72
IndicoV2/Exception
   FileUploadException.cs100%0%0%10, 11, 12, 15
   GraphQLException.cs0%0%0%11, 13, 15, 17, 21, 25, 26, 27, 28, 28, 28, 30, 32
IndicoV2/Extensions/DataSets
   DataSetAwaiter.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders
   JobResultBuilder.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission
   UrlJobResult.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission/Exceptions
   InvalidJobSubmissionResult.cs100%50%50%9
   InvalidUrlException.cs100%50%50%9
IndicoV2/Extensions/Jobs
   JobAwaiter.cs100%75%93.33%31
IndicoV2/Extensions/SubmissionResult
   SubmissionResultAwaiter.cs100%100%100%
IndicoV2/Extensions/Workflows
   WorkflowAwaiter.cs0%50%25%17, 17, 17, 19, 21
IndicoV2/GraphQLRequest
   GraphQLRequestClient.cs0%0%0%17, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 32, 32, 32, 34, 36, 37, 38, 39, 40, 42, 43, 43, 43, 45, 48, 48, 48, 49, 50
IndicoV2/Jobs
   JobsClient.cs0%25%20%25, 26, 27, 31, 33, 34, 38, 39, 40, 40, 40, 42, 43, 45, 46, 47, 49, 50
IndicoV2/Models
   ModelsClient.cs0%14.29%13.79%28, 29, 30, 36, 37, 38, 43, 44, 45, 49, 50, 51, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 54, 55, 56, 57, 58, 60, 61, 62, 63, 64, 65, 66
IndicoV2/Ocr
   OcrClient.cs0%20%11.43%28, 29, 30, 31, 36, 37, 38, 38, 38, 40, 41, 42, 43, 44, 45, 47, 48, 49, 50, 51, 53, 55, 56, 57, 58, 60, 62, 63, 65, 69, 70, 72, 74
IndicoV2/Reviews
   ReviewsClient.cs100%33.33%66.67%22, 25
IndicoV2/Storage
   Blob.cs100%0%0%15, 17, 23, 31, 32, 41, 42, 51, 52
   FileParameter.cs100%0%0%10, 7, 8, 9
   MultipartFormUpload.cs0%0%0%16, 18, 22, 22, 22, 23, 24, 25, 26, 27, 28, 29, 33, 34, 35, 36, 37, 39, 39, 39, 42, 42, 42, 44, 47, 49, 50, 51, 52, 53, 55, 56, 57, 60, 61, 64, 65, 66, 67, 70, 71, 72, 73, 74
   RetrieveBlob.cs0%0%0%19, 21, 23, 24, 24, 24, 25, 32, 42, 43, 44, 45, 46, 50, 51, 51, 51, 53, 57, 59, 67, 68, 69, 69, 69, 71, 75, 77, 85, 86, 87
   StorageClient.cs0%11.11%13.33%100, 103, 105, 106, 107, 108, 110, 111, 112, 115, 116, 119, 120, 121, 122, 125, 126, 127, 129, 130, 29, 35, 36, 38, 39, 43, 45, 46, 50, 51, 53, 58, 59, 61, 67, 72, 73, 75, 77, 79, 80, 81, 82, 83, 85, 89, 90, 91, 92, 93, 95, 95, 95, 98, 98, 98
   UploadFile.cs0%0%0%14, 21, 22, 25, 29, 29, 29, 31, 32, 33, 35, 35, 35, 37, 40, 40, 40, 42, 46, 49, 57, 59, 59, 59, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 73, 74, 75, 76, 77, 80, 82, 82, 82, 84, 85, 85, 85, 87, 88, 90, 94, 95
   UploadStream.cs0%0%0%18, 20, 28, 30, 30, 30, 32, 33, 34, 35, 36, 37, 38, 39, 40, 43, 44, 45, 46, 47, 49, 49, 49, 51, 52, 52, 52, 54, 55, 56, 60, 61
IndicoV2/Submissions
   SubmissionsClient.cs0%8.33%5%101, 101, 101, 103, 104, 105, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 123, 124, 124, 124, 126, 128, 128, 128, 128, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 144, 148, 149, 150, 150, 150, 150, 150, 151, 153, 28, 29, 30, 31, 32, 33, 34, 34, 34, 36, 37, 38, 39, 40, 41, 43, 44, 45, 46, 47, 49, 51, 51, 51, 52, 56, 57, 57, 57, 58, 64, 68, 73, 74, 74, 74, 76, 76, 76, 78, 79, 83, 87, 88, 94, 95, 96
IndicoV2/Workflows
   WorkflowsClient.cs100%14.29%20%23, 24, 25, 29, 30, 31, 35, 36, 37, 40, 43, 45, 46, 47, 48, 49

@nateshim-indico nateshim-indico marked this pull request as ready for review March 6, 2024 22:00
@nateshim-indico nateshim-indico changed the title implement submission filter parity [DEV-11445] implement submission filter parity Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Total Coverage: 15.77%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
IndicoV2
   IndicoClient.cs100%71.43%86.96%30, 79, 80
   IndicoClientExtensions.cs100%92.31%92.31%85
IndicoV2.Abstractions/CommonModels/Pagination
   HasCursor.cs100%0%0%11, 9
   PageInfo.cs100%0%0%13, 17, 21, 25
IndicoV2.Abstractions/CommonModels/Predictions
   Prediction.cs100%0%0%12, 15, 18, 21, 9
IndicoV2.Abstractions/Converters
   CastingConverter.cs0%0%0%12, 14, 18, 18, 18, 20, 9
IndicoV2.Abstractions/DataSets/Models
   DataSet.cs100%0%0%5, 6
   DataSetFull.cs100%0%0%10, 11, 12, 7, 8, 9
IndicoV2.Abstractions/Extensions/SubmissionResult/Exceptions
   WrongSubmissionStatusException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Jobs/Exceptions
   JobNotSuccessfulException.cs100%33.33%33.33%11, 13
IndicoV2.Abstractions/Models/Models
   Model.cs100%0%0%5, 6, 7
   ModelGroup.cs100%0%0%5, 6, 7, 8
   ModelGroupBase.cs100%0%0%5
   PredictionJobResult.cs100%0%0%15, 17, 19, 21, 24
IndicoV2.Abstractions/Ocr/Models
   ExtractionJobResult.cs100%0%0%10
IndicoV2.Abstractions/Storage/Models
   FileMetadata.cs100%0%0%11, 14, 17, 8
IndicoV2.Abstractions/Submissions/Models
   AndFilter.cs100%0%0%10
   SubmissionFilter.cs100%0%0%21, 22
   FilterConverter.cs0%0%0%17, 17, 17, 20, 21, 21, 21, 23, 25, 25, 25, 27, 29, 29, 29, 31, 33, 33, 33, 35, 35, 35, 37, 37, 37, 39, 40, 41, 42, 43, 44, 46, 46, 46, 48, 50, 50, 50, 52, 54, 54, 54, 56, 57, 58, 59, 60, 62, 62, 62, 64, 65, 66, 67, 68, 70, 72, 72, 72, 74, 75, 76, 77, 80, 80, 80, 82, 83, 84, 85, 87
   OrFilter.cs100%0%0%10
   Submission.cs100%0%0%104, 109, 114, 119, 78, 83, 88, 93, 99
   Submission.cs100%0%0%156, 161, 166, 171, 176, 181, 186, 191, 196, 201, 206, 211, 216, 221, 226, 231, 236, 241, 246, 251, 256
   Submission.cs100%0%0%12, 17, 22, 27, 32, 37, 42
   SubmissionFilter.cs100%0%0%27, 28, 30, 32, 34, 36, 38, 40, 42
   Submission.cs100%0%0%50, 55, 60, 65, 70
   Submission.cs100%0%0%128, 133, 138, 143, 148
   SubmissionFilter.cs100%0%0%14, 15, 16
   Submission.cs0%0%0%262, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 290, 290, 291, 291, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 329, 329, 329, 329, 329, 329, 329, 329, 329, 329, 332, 334, 336, 338, 340, 342, 344
IndicoV2.Abstractions/Workflows/Models
   Workflow.cs100%0%0%10, 11, 12
IndicoV2/DataSets
   DataSetClient.cs0%11.11%11.76%26, 27, 27, 27, 27, 27, 28, 29, 33, 34, 34, 34, 34, 34, 35, 36, 41, 42, 43, 45, 46, 50, 53, 56, 58, 59, 60, 61, 62, 64, 64, 64, 65, 66, 67, 68, 69, 70, 71, 72
IndicoV2/Exception
   FileUploadException.cs100%0%0%10, 11, 12, 15
   GraphQLException.cs0%0%0%11, 13, 15, 17, 21, 25, 26, 27, 28, 28, 28, 30, 32
IndicoV2/Extensions/DataSets
   DataSetAwaiter.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders
   JobResultBuilder.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission
   UrlJobResult.cs100%100%100%
IndicoV2/Extensions/JobResultBuilders/Submission/Exceptions
   InvalidJobSubmissionResult.cs100%50%50%9
   InvalidUrlException.cs100%50%50%9
IndicoV2/Extensions/Jobs
   JobAwaiter.cs100%75%93.33%31
IndicoV2/Extensions/SubmissionResult
   SubmissionResultAwaiter.cs100%100%100%
IndicoV2/Extensions/Workflows
   WorkflowAwaiter.cs0%50%25%17, 17, 17, 19, 21
IndicoV2/GraphQLRequest
   GraphQLRequestClient.cs0%0%0%17, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 32, 32, 32, 34, 36, 37, 38, 39, 40, 42, 43, 43, 43, 45, 48, 48, 48, 49, 50
IndicoV2/Jobs
   JobsClient.cs0%25%20%25, 26, 27, 31, 33, 34, 38, 39, 40, 40, 40, 42, 43, 45, 46, 47, 49, 50
IndicoV2/Models
   ModelsClient.cs0%14.29%13.79%28, 29, 30, 36, 37, 38, 43, 44, 45, 49, 50, 51, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 53, 54, 55, 56, 57, 58, 60, 61, 62, 63, 64, 65, 66
IndicoV2/Ocr
   OcrClient.cs0%20%11.43%28, 29, 30, 31, 36, 37, 38, 38, 38, 40, 41, 42, 43, 44, 45, 47, 48, 49, 50, 51, 53, 55, 56, 57, 58, 60, 62, 63, 65, 69, 70, 72, 74
IndicoV2/Reviews
   ReviewsClient.cs100%33.33%66.67%22, 25
IndicoV2/Storage
   Blob.cs100%0%0%15, 17, 23, 31, 32, 41, 42, 51, 52
   FileParameter.cs100%0%0%10, 7, 8, 9
   MultipartFormUpload.cs0%0%0%16, 18, 22, 22, 22, 23, 24, 25, 26, 27, 28, 29, 33, 34, 35, 36, 37, 39, 39, 39, 42, 42, 42, 44, 47, 49, 50, 51, 52, 53, 55, 56, 57, 60, 61, 64, 65, 66, 67, 70, 71, 72, 73, 74
   RetrieveBlob.cs0%0%0%19, 21, 23, 24, 24, 24, 25, 32, 42, 43, 44, 45, 46, 50, 51, 51, 51, 53, 57, 59, 67, 68, 69, 69, 69, 71, 75, 77, 85, 86, 87
   StorageClient.cs0%11.11%13.33%100, 103, 105, 106, 107, 108, 110, 111, 112, 115, 116, 119, 120, 121, 122, 125, 126, 127, 129, 130, 29, 35, 36, 38, 39, 43, 45, 46, 50, 51, 53, 58, 59, 61, 67, 72, 73, 75, 77, 79, 80, 81, 82, 83, 85, 89, 90, 91, 92, 93, 95, 95, 95, 98, 98, 98
   UploadFile.cs0%0%0%14, 21, 22, 25, 29, 29, 29, 31, 32, 33, 35, 35, 35, 37, 40, 40, 40, 42, 46, 49, 57, 59, 59, 59, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 73, 74, 75, 76, 77, 80, 82, 82, 82, 84, 85, 85, 85, 87, 88, 90, 94, 95
   UploadStream.cs0%0%0%18, 20, 28, 30, 30, 30, 32, 33, 34, 35, 36, 37, 38, 39, 40, 43, 44, 45, 46, 47, 49, 49, 49, 51, 52, 52, 52, 54, 55, 56, 60, 61
IndicoV2/Submissions
   SubmissionsClient.cs0%8.33%5%101, 101, 101, 103, 104, 105, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 123, 124, 124, 124, 126, 128, 128, 128, 128, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 144, 148, 149, 150, 150, 150, 150, 150, 151, 153, 28, 29, 30, 31, 32, 33, 34, 34, 34, 36, 37, 38, 39, 40, 41, 43, 44, 45, 46, 47, 49, 51, 51, 51, 52, 56, 57, 57, 57, 58, 64, 68, 73, 74, 74, 74, 76, 76, 76, 78, 79, 83, 87, 88, 94, 95, 96
IndicoV2/Workflows
   WorkflowsClient.cs100%14.29%20%23, 24, 25, 29, 30, 31, 35, 36, 37, 40, 43, 45, 46, 47, 48, 49

@nateshim-indico nateshim-indico merged commit 8e7acc0 into master Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goatrocks goatrocks goatrocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nateshim-indico @goatrocks