[CAT-323] Remove references to "load" #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Total Coverage: 33.01% Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
goatrocks
requested changes
Sep 25, 2023
| @@ -29,6 +29,8 @@ internal class IndicoTestContainerBuilder | |||
|
|
|||
| public IUnityContainer Build() | |||
| { | |||
| Console.WriteLine(BaseUrl); | |||
There was a problem hiding this comment.
please remove these console logs
| /// <param name="modelId"><seealso cref="IModel"/>'s Id</param> | ||
| /// <param name="cancellationToken"><c><see cref="CancellationToken"/></c> for handling cancellation of asynchronous operations.</param> | ||
| /// <returns>Status</returns> | ||
| Task<string> LoadModel(int modelId, CancellationToken cancellationToken); |
There was a problem hiding this comment.
I know this is more work, but I would like to mark this as @ deprecated and make the underlying call return a no-op/success by default. We don't want to delete API calls without first marking them deprecated so users can migrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this was completely necessary because the ModelGroupPredict integration tests were passing without it. But if we just want to clean up the repo a bit then this is a good move